Why is install putting modbus.h in 2 places? #290

Closed
dansut opened this Issue Oct 15, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@dansut

dansut commented Oct 15, 2015

I'll preface that this is not specifically an issue, I was just attempting to build an RPM of 3.1.2 of your excellent library and the rpmbuild made me aware that modbus.h was being installed a second time in /usr/include/libmodbus as well as its traditional location of /usr/include/modbus.

I tracked down why this was happening, looks like it is to support pkg-config, and made a note in commit 03e9d63 but am still relatively new to GitHub so not 100% sure if you will be notified of that.

I initially fixed by adding a pkgincludedir = ${includedir}/modbus but this just made the install put it in the same place twice - and I felt it was best to try and understand the why before changing anything. The way you have pkg-config setup it looks like it does not use the ${includedir}/libmodbus but I do not claim to be any sort of expert in this.

Thanks for any time you can spend explaining this to me.

@stephane stephane closed this in 69e1e22 Oct 15, 2015

@stephane

This comment has been minimized.

Show comment
Hide comment
@stephane

stephane Oct 15, 2015

Owner

Thank you @dansut!

Owner

stephane commented Oct 15, 2015

Thank you @dansut!

georgidimov added a commit to georgidimov/libmodbus that referenced this issue Jul 24, 2017

Remove duplicate install of modbus.h (closes #290)
The file was copied in wrong place too (include/libmodbus).
Thanks to Daniel Sutcliffe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment