Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace is suboptimal in the registries #182

Closed
stephanenicolas opened this issue Jan 3, 2017 · 2 comments
Closed

Replace is suboptimal in the registries #182

stephanenicolas opened this issue Jan 3, 2017 · 2 comments
Assignees
@dlemures
Labels
enhancement has PR
Milestone
1.0.4

Comments

@stephanenicolas
Copy link
Owner

stephanenicolas commented Jan 3, 2017 •
edited

We do a replace operation in the registries to lookup for the factories and member injectors, before bucketing. But this is so suboptimal: the bucket entries themselves should be replaced and the match should be direct.

image
@dlemures dlemures self-assigned this Jan 3, 2017
@dlemures dlemures added this to the 1.0.4 milestone Jan 3, 2017
@dlemures dlemures mentioned this issue Jan 3, 2017
Merged
@dlemures
Copy link
Collaborator

dlemures commented Jan 3, 2017

PR: #184

@dlemures dlemures added the has PR label Jan 4, 2017
@dlemures
Copy link
Collaborator

dlemures commented Jan 4, 2017

PR merged

@dlemures dlemures closed this as completed Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlemures dlemures

Labels
enhancement has PR
Projects
None yet
Milestone
1.0.4
Development

No branches or pull requests
2 participants
@stephanenicolas @dlemures