{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":634321852,"defaultBranch":"main","name":"swift","ownerLogin":"stephank","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-04-29T18:44:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/89950?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1690832497.0","currentOid":""},"activityList":{"items":[{"before":"e4b77974c14395ea66f20316161554eb3f699a46","after":"11976488f47be84624dcf60ce25e3102c5064716","ref":"refs/heads/fix/5.9-cmake-3.25","pushedAt":"2023-08-21T17:10:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"stephank","name":"Stéphan Kochen","path":"/stephank","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89950?s=80&v=4"},"commit":{"message":"build: fix accidental cmake expansions\n\nAs of CMake 3.25, there are now global variables `LINUX=1`, `ANDROID=1`,\netc. These conflict with expressions that used these names as unquoted\nstrings in positions where CMake accepts 'variable|string', for example:\n\n- `if(sdk STREQUAL LINUX)` would fail, because `LINUX` is now defined and\n  expands to 1, where it would previously coerce to a string.\n\n- `if(${sdk} STREQUAL \"LINUX\")` would fail if `sdk=LINUX`, because the\n  left-hand side expands twice.\n\nIn this patch, I looked for a number of patterns to fix up, sometimes a\nlittle defensively:\n\n- Quoted right-hand side of `STREQUAL` where I was confident it was\n  intended to be a string literal.\n\n- Removed manual variable expansion on left-hand side of `STREQUAL`,\n  `MATCHES` and `IN_LIST` where I was confident it was unintended.\n\nFixes #65028.","shortMessageHtmlLink":"build: fix accidental cmake expansions"}},{"before":null,"after":"e4b77974c14395ea66f20316161554eb3f699a46","ref":"refs/heads/fix/5.9-cmake-3.25","pushedAt":"2023-07-31T19:41:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"stephank","name":"Stéphan Kochen","path":"/stephank","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89950?s=80&v=4"},"commit":{"message":"build: fix accidental cmake expansions\n\nAs of CMake 3.25, there are now global variables `LINUX=1`, `ANDROID=1`,\netc. These conflict with expressions that used these names as unquoted\nstrings in positions where CMake accepts 'variable|string', for example:\n\n- `if(sdk STREQUAL LINUX)` would fail, because `LINUX` is now defined and\n  expands to 1, where it would previously coerce to a string.\n\n- `if(${sdk} STREQUAL \"LINUX\")` would fail if `sdk=LINUX`, because the\n  left-hand side expands twice.\n\nIn this patch, I looked for a number of patterns to fix up, sometimes a\nlittle defensively:\n\n- Quoted right-hand side of `STREQUAL` where I was confident it was\n  intended to be a string literal.\n\n- Removed manual variable expansion on left-hand side of `STREQUAL`,\n  `MATCHES` and `IN_LIST` where I was confident it was unintended.\n\nFixes #65028.","shortMessageHtmlLink":"build: fix accidental cmake expansions"}},{"before":"47bff26ea40cbc7988a1fd2b6750b43357396087","after":"7b460ce4951c32dbcc0bdeecf1bbb1f67075d429","ref":"refs/heads/fix/cmake-3.25","pushedAt":"2023-07-17T19:51:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"stephank","name":"Stéphan Kochen","path":"/stephank","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89950?s=80&v=4"},"commit":{"message":"build: fix accidental cmake expansions\n\nAs of CMake 3.25, there are now global variables `LINUX=1`, `ANDROID=1`,\netc. These conflict with expressions that used these names as unquoted\nstrings in positions where CMake accepts 'variable|string', for example:\n\n- `if(sdk STREQUAL LINUX)` would fail, because `LINUX` is now defined and\n  expands to 1, where it would previously coerce to a string.\n\n- `if(${sdk} STREQUAL \"LINUX\")` would fail if `sdk=LINUX`, because the\n  left-hand side expands twice.\n\nIn this patch, I looked for a number of patterns to fix up, sometimes a\nlittle defensively:\n\n- Quoted right-hand side of `STREQUAL` where I was confident it was\n  intended to be a string literal.\n\n- Removed manual variable expansion on left-hand side of `STREQUAL`,\n  `MATCHES` and `IN_LIST` where I was confident it was unintended.\n\nFixes #65028.","shortMessageHtmlLink":"build: fix accidental cmake expansions"}},{"before":"95a6dc88f77f03619a325c5720b5ec4ae2708160","after":"47bff26ea40cbc7988a1fd2b6750b43357396087","ref":"refs/heads/fix/cmake-3.25","pushedAt":"2023-06-29T19:55:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"stephank","name":"Stéphan Kochen","path":"/stephank","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89950?s=80&v=4"},"commit":{"message":"build: fix accidental cmake expansions\n\nAs of CMake 3.25, there are now global variables `LINUX=1`, `ANDROID=1`,\netc. These conflict with expressions that used these names as unquoted\nstrings in positions where CMake accepts 'variable|string', for example:\n\n- `if(sdk STREQUAL LINUX)` would fail, because `LINUX` is now defined and\n  expands to 1, where it would previously coerce to a string.\n\n- `if(${sdk} STREQUAL \"LINUX\")` would fail if `sdk=LINUX`, because the\n  left-hand side expands twice.\n\nIn this patch, I looked for a number of patterns to fix up, sometimes a\nlittle defensively:\n\n- Quoted right-hand side of `STREQUAL` where I was confident it was\n  intended to be a string literal.\n\n- Removed manual variable expansion on left-hand side of `STREQUAL`,\n  `MATCHES` and `IN_LIST` where I was confident it was unintended.\n\nFixes #65028.","shortMessageHtmlLink":"build: fix accidental cmake expansions"}},{"before":"73ae77e2b6f1723fff83317cffa5f204f5d2e5fb","after":"95a6dc88f77f03619a325c5720b5ec4ae2708160","ref":"refs/heads/fix/cmake-3.25","pushedAt":"2023-06-07T19:23:25.149Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"stephank","name":"Stéphan Kochen","path":"/stephank","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89950?s=80&v=4"},"commit":{"message":"build: fix accidental cmake expansions\n\nAs of CMake 3.25, there are now global variables `LINUX=1`, `ANDROID=1`,\netc. These conflict with expressions that used these names as unquoted\nstrings in positions where CMake accepts 'variable|string', for example:\n\n- `if(sdk STREQUAL LINUX)` would fail, because `LINUX` is now defined and\n  expands to 1, where it would previously coerce to a string.\n\n- `if(${sdk} STREQUAL \"LINUX\")` would fail if `sdk=LINUX`, because the\n  left-hand side expands twice.\n\nIn this patch, I looked for a number of patterns to fix up, sometimes a\nlittle defensively:\n\n- Quoted right-hand side of `STREQUAL` where I was confident it was\n  intended to be a string literal.\n\n- Removed manual variable expansion on left-hand side of `STREQUAL`,\n  `MATCHES` and `IN_LIST` where I was confident it was unintended.\n\nFixes #65028.","shortMessageHtmlLink":"build: fix accidental cmake expansions"}},{"before":null,"after":"112681f7f5927588569b225d926ca9f5f9ec98b3","ref":"refs/heads/fix/5.8-cmake-3.25","pushedAt":"2023-04-30T12:17:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"stephank","name":"Stéphan Kochen","path":"/stephank","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89950?s=80&v=4"},"commit":{"message":"build: fix accidental cmake expansions\n\nAs of CMake 3.25, there are now global variables `LINUX=1`, `ANDROID=1`,\netc. These conflict with expressions that used these names as unquoted\nstrings in positions where CMake accepts 'variable|string', for example:\n\n- `if(sdk STREQUAL LINUX)` would fail, because `LINUX` is now defined and\n  expands to 1, where it would previously coerce to a string.\n\n- `if(${sdk} STREQUAL \"LINUX\")` would fail if `sdk=LINUX`, because the\n  left-hand side expands twice.\n\nIn this patch, I looked for a number of patterns to fix up, sometimes a\nlittle defensively:\n\n- Quoted right-hand side of `STREQUAL` where I was confident it was\n  intended to be a string literal.\n\n- Removed manual variable expansion on left-hand side of `STREQUAL`,\n  `MATCHES` and `IN_LIST` where I was confident it was unintended.\n\nFixes #65028.","shortMessageHtmlLink":"build: fix accidental cmake expansions"}},{"before":"d1db7d23aef4ed8127d07ee82b28fc949011810b","after":"73ae77e2b6f1723fff83317cffa5f204f5d2e5fb","ref":"refs/heads/fix/cmake-3.25","pushedAt":"2023-04-30T12:07:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"stephank","name":"Stéphan Kochen","path":"/stephank","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89950?s=80&v=4"},"commit":{"message":"build: fix accidental cmake expansions\n\nAs of CMake 3.25, there are now global variables `LINUX=1`, `ANDROID=1`,\netc. These conflict with expressions that used these names as unquoted\nstrings in positions where CMake accepts 'variable|string', for example:\n\n- `if(sdk STREQUAL LINUX)` would fail, because `LINUX` is now defined and\n  expands to 1, where it would previously coerce to a string.\n\n- `if(${sdk} STREQUAL \"LINUX\")` would fail if `sdk=LINUX`, because the\n  left-hand side expands twice.\n\nIn this patch, I looked for a number of patterns to fix up, sometimes a\nlittle defensively:\n\n- Quoted right-hand side of `STREQUAL` where I was confident it was\n  intended to be a string literal.\n\n- Removed manual variable expansion on left-hand side of `STREQUAL`,\n  `MATCHES` and `IN_LIST` where I was confident it was unintended.\n\nFixes #65028.","shortMessageHtmlLink":"build: fix accidental cmake expansions"}},{"before":"7cbf2788160a0b57f543e6368c0ca1f7ea365978","after":"d1db7d23aef4ed8127d07ee82b28fc949011810b","ref":"refs/heads/fix/cmake-3.25","pushedAt":"2023-04-30T12:06:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"stephank","name":"Stéphan Kochen","path":"/stephank","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89950?s=80&v=4"},"commit":{"message":"build: fix accidental cmake expansions\n\nAs of CMake 3.25, there are now global variables `LINUX=1`, `ANDROID=1`,\netc. These conflict with expressions that used these names as unquoted\nstrings in positions where CMake accepts 'variable|string', for example:\n\n- `if(sdk STREQUAL LINUX)` would fail, because `LINUX` is now defined and\n  expands to 1, where it would previously coerce to a string.\n\n- `if(${sdk} STREQUAL \"LINUX\")` would fail if `sdk=LINUX`, because the\n  left-hand side expands twice.\n\nIn this patch, I looked for a number of patterns to fix up, sometimes a\nlittle defensively:\n\n- Quoted right-hand side of `STREQUAL` where I was confident it was\n  intended to be a string literal.\n\n- Removed manual variable expansion on left-hand side of `STREQUAL`,\n  `MATCHES` and `IN_LIST` where I was confident it was unintended.","shortMessageHtmlLink":"build: fix accidental cmake expansions"}},{"before":"5223fa23990b0aba0b837c03669f453c9a47feee","after":"7cbf2788160a0b57f543e6368c0ca1f7ea365978","ref":"refs/heads/fix/cmake-3.25","pushedAt":"2023-04-29T19:00:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"stephank","name":"Stéphan Kochen","path":"/stephank","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89950?s=80&v=4"},"commit":{"message":"build: fix accidental cmake expansions\n\nAs of CMake 3.25, there are now global variables `LINUX=1`, `ANDROID=1`, etc.\nThese conflict with expression that used them unquoted in positions\nwhere CMake accepts 'variable|string', for example:\n\n- `if(sdk STREQUAL LINUX)` would fail, because `LINUX` is now defined and\n  expands to 1, where it would previously coerce to a string.\n\n- `if(${sdk} STREQUAL \"LINUX\")` would fail if `sdk=LINUX`, because the\n  left-hand side expands twice.\n\nIn this change, I looked for a number of patterns to fix up, sometimes a\nlittle defensively:\n\n- Quoted right-hand side of `STREQUAL` where I was confident it was\n  intended to be a string literal.\n\n- Removed manual variable expansion on left-hand side of `STREQUAL`,\n  `MATCHES` and `IN_LIST` where I was confident it was unintended.","shortMessageHtmlLink":"build: fix accidental cmake expansions"}},{"before":null,"after":"5223fa23990b0aba0b837c03669f453c9a47feee","ref":"refs/heads/fix/cmake-3.25","pushedAt":"2023-04-29T18:44:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"stephank","name":"Stéphan Kochen","path":"/stephank","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/89950?s=80&v=4"},"commit":{"message":"build: fix accidental cmake expansions\n\nMany expressions were written as `if(${foobar} ...`, with the variable\nexpansion in a position where CMake expects 'variable|string'. This is\nambiguous, because of the value of `${foobar}` happens to be a variable\nname, CMake would treat the value as another variable name.\n\nAs of CMake 3.25, there are now global variables `LINUX=1`, `ANDROID=1`, etc.\nthat conflict with our SDK naming. As a result, an expression like:\n\n  if(${sdk} STREQUAL LINUX)\n\nmay actually expand to:\n\n  if(\"1\" STREQUAL \"1\")\n\nwhich will happen to succeed, but there are many cases where we are not\nso lucky, for example:\n\n  if(${sdk} IN_LIST SWIFT_LIBSTDCXX_PLATFORMS)\n\nThis commit makes a couple of changes:\n\n- Change unquoted `${sdk}` in an expression 'variable|string' position to just\n  `sdk`.\n\n- Quote platform constants (`LINUX`, `ANDROID`, etc.) used in\n  expressions, to force CMake to interpret them as strings.","shortMessageHtmlLink":"build: fix accidental cmake expansions"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADbz84BgA","startCursor":null,"endCursor":null}},"title":"Activity · stephank/swift"}