Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page turn effect #161

Closed
jmpeltier opened this issue Oct 26, 2019 · 7 comments
Closed

Page turn effect #161

jmpeltier opened this issue Oct 26, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request I'd like to help but it's difficult You've raised an issue that's just right - but for some reason, it's hard to solve.

Comments

@jmpeltier
Copy link

It would be nice to add a page turn effect as you page through a document. In order to do this, it might make sense to also limit the number of pages to be shown to 2. It would create more of a book or magazine experience.

Example: https://flowpaper.com/flipbook-software/

@stephanrauh
Copy link
Owner

stephanrauh commented Oct 26, 2019

I'd love to do so! However, I don't have a clue how to do it. I'm pretty sure the idea is well beyond the scope of the original pdf.js project, so I hardly dare to ask @Snuffleupagus, @timvandermeij, and the rest of the team to chime in. However, since I've just done that: guys, what's your opinion?

@stephanrauh stephanrauh self-assigned this Oct 26, 2019
@stephanrauh stephanrauh added the enhancement New feature or request label Oct 26, 2019
@stephanrauh
Copy link
Owner

Basically, that's two questions:

  • Is it possible to modify pdf.js in such a way it supports page-turn effect?
    (I'm almost sure the answer is a clear "yes", and I'm 90% sure I'm up to the task).
  • Can we add the feature to pdf.js without destroying the core features?

Bonus question: just imagining I'd manage to implement that feauture, would you, @timvandermeij and @Snuffleupagus, accept my pull request?

@timvandermeij
Copy link

This is not something we would consider for the general PDF.js viewer since it only applies to a very specific use case. However, at https://github.com/mozilla/pdf.js/wiki/Gallery-of-user-projects-and-modifications there are some project that forked PDF.js and implemented this feature; see https://github.com/RaffaeleMorganti/pdf-viewer for example.

@stephanrauh
Copy link
Owner

@timvandermeij Thanks! I'm surprise someone has managed to do this, while keeping the rest of the functionality. Awesome!

BTW, may I kindly ask you to include ngx-extended-pdf-viewer to your gallery? It's a Angular integration that's recently becoming surprisingly popular.

@timvandermeij
Copy link

Done! It's always nice for us to see PDF.js being used in all kinds of cool projects.

@stephanrauh stephanrauh added the Working on it I've started to work on this ticket. More often than not, that means the feature is delivered soon. label Nov 16, 2019
@stephanrauh stephanrauh removed the Working on it I've started to work on this ticket. More often than not, that means the feature is delivered soon. label Dec 16, 2019
@stephanrauh
Copy link
Owner

I'm putting this aside for a while. I've managed to implement a book mode, but currently, it's bug-ridden and slow. I plan to start fresh later.

@stephanrauh stephanrauh added the I'd like to help but it's difficult You've raised an issue that's just right - but for some reason, it's hard to solve. label Jan 13, 2020
@stephanrauh
Copy link
Owner

I'm closing the ticket for the moment. Nonetheless, I'll keep it in mind. I like the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request I'd like to help but it's difficult You've raised an issue that's just right - but for some reason, it's hard to solve.
Projects
None yet
Development

No branches or pull requests

3 participants