-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page turn effect #161
Comments
I'd love to do so! However, I don't have a clue how to do it. I'm pretty sure the idea is well beyond the scope of the original pdf.js project, so I hardly dare to ask @Snuffleupagus, @timvandermeij, and the rest of the team to chime in. However, since I've just done that: guys, what's your opinion? |
Basically, that's two questions:
Bonus question: just imagining I'd manage to implement that feauture, would you, @timvandermeij and @Snuffleupagus, accept my pull request? |
This is not something we would consider for the general PDF.js viewer since it only applies to a very specific use case. However, at https://github.com/mozilla/pdf.js/wiki/Gallery-of-user-projects-and-modifications there are some project that forked PDF.js and implemented this feature; see https://github.com/RaffaeleMorganti/pdf-viewer for example. |
@timvandermeij Thanks! I'm surprise someone has managed to do this, while keeping the rest of the functionality. Awesome! BTW, may I kindly ask you to include ngx-extended-pdf-viewer to your gallery? It's a Angular integration that's recently becoming surprisingly popular. |
Done! It's always nice for us to see PDF.js being used in all kinds of cool projects. |
I'm putting this aside for a while. I've managed to implement a book mode, but currently, it's bug-ridden and slow. I plan to start fresh later. |
I'm closing the ticket for the moment. Nonetheless, I'll keep it in mind. I like the idea. |
It would be nice to add a page turn effect as you page through a document. In order to do this, it might make sense to also limit the number of pages to be shown to 2. It would create more of a book or magazine experience.
Example: https://flowpaper.com/flipbook-software/
The text was updated successfully, but these errors were encountered: