Notes.filterDirectories not filtering directories passed in. #5

Open
Duder-onomy opened this Issue Sep 11, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@Duder-onomy

Hello.
Thanks for the awesome addition to node! This feature was awesome in rails, will be just as useful in node apps.

The filter directories array defined on line 32 of notes.js does not filter directories added to it.

Maybe I am not understanding your intention, but should this not skip the directories listed?

Notes.filterDirectories = ["node_modules", "app/vendor", "build"];

Notes does not skip the app/vendor or build directories.

Thanks
Greg

@ahmadassaf

This comment has been minimized.

Show comment
Hide comment
@ahmadassaf

ahmadassaf Feb 26, 2017

@Duder-onomy i have just published a similar module with this issue fixed on https://github.com/ahmadassaf/code-notes

ahmadassaf commented Feb 26, 2017

@Duder-onomy i have just published a similar module with this issue fixed on https://github.com/ahmadassaf/code-notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment