Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

let mail() return a mailing object #5

Merged
merged 1 commit into from Oct 5, 2012

Conversation

Projects
None yet
3 participants
Contributor

einarmagnus commented Mar 15, 2012

This allows us to continue to do MailerClass.mailer_method.deliver

Let mail() and create!() return what their overridden versions do.
This allows us to continue to do MailerClass.mailer_method.deliver

It should be better to use super.tap or returning() for preserve the return value

Owner

einarmagnus replied Jun 21, 2012

Perhaps. Semantically there is no difference, but it may be safer if someone edits this further.

stephenb added a commit that referenced this pull request Oct 5, 2012

Merge pull request #5 from einarmagnus/master
let mail() return a mailing object

@stephenb stephenb merged commit ed2dede into stephenb:master Oct 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment