Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.11.6 #902

Merged
merged 11 commits into from Apr 19, 2019

Conversation

@sburlewapg
Copy link
Contributor

commented Apr 3, 2019

Per recent discussion, this bumps the version to 0.11.6 and updates the project to Swift 5.

First time contributing, so please forgive anything I've missed in this.

One change in Foundation.swift I'm not 100% sure about because it required force unwrapping pointer.baseAddress within withUnsafeBytes, but I wasn't able to find anything less invasive to the current implementation.

sburlewapg added some commits Mar 30, 2019

Swift 5
- Passed through project language version setting to framework & unit test targets
- Bumped version to 0.11.6 in documentation & pod spec
- Fixed build warnings in unit test code for Swift 5
@sburlewapg sburlewapg referenced this pull request Apr 3, 2019
@ypopovych

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

Can it be built with swift 4.2 after these changes?
Because maybe we will need to release 2 versions.
One fixed with swift 4.2 + fixes for it and one for swift 5 with a version bump to 0.12

@sburlewapg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

@ypopovych It still builds with Swift 4.2, yes. All the unit tests pass for both 4.2 and 5. Would you prefer if I switched the language back to 4.2, and then made another PR for version 0.12 with swift 5?

@ypopovych

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

I need to think about this. How should we approach it

@sburlewapg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Ok, let me know what you decide and I'll update the PR (and make another one if needed).

@sburlewapg sburlewapg changed the title Version 0.11.6, Swift 5 Version 0.11.6 Apr 4, 2019

@sburlewapg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

@ypopovych I've updated the PR with Swift 4.2, after this the only necessary changes to adopt Swift 5 will be version bumps where needed and the language version in the build settings. Let me know what I can do to help expedite this.

@karishmapujara

This comment has been minimized.

Copy link

commented Apr 4, 2019

Please release for Swift 5.

@ypopovych

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

@sburlewapg can you check what's going on with tests?

@sburlewapg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@ypopovych will do. I also need to update a couple other pieces of documentation that slipped through anyway, should have some more info on the test failures today.

sburlewapg added some commits Apr 5, 2019

Changed Xcode back to 10.2 for CI config and documentation (apparentl…
…y `withUnsafeBytes` doesn't use UnsafeRawBufferPointer prior to 10.2)
@sburlewapg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@timshadel I'll give that a try. Thanks for the tip!

@sburlewapg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@timshadel changing the simulator device doesn't seem to fix the tests. I saw some differences in the logs between the travis builds, I'm not super familiar with it so I'm still not sure what's wrong with them.

Comparison of VALIDATOR_SUBSPEC="none" build logs:

@timshadel:
-> Pod installation complete! There is 1 dependency from the Podfile and 1 total pod installed.
Building with xcodebuild.
$ /usr/bin/xcodebuild build -workspace /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/CocoaPods-Lint-20190409-54818-199z9t1-SQLite.swift/App.xcworkspace -scheme App -configuration Release CODE_SIGN_IDENTITY=- -sdk iphonesimulator -destination id=A47AA654-440F-4A92-9A83-669B55D7B6FE
Build settings from command line:
CODE_SIGN_IDENTITY = -
SDKROOT = iphonesimulator12.1

Mine:
-> Pod installation complete! There is 1 dependency from the Podfile and 1 total pod installed.
Building with xcodebuild.
nil versions are discouraged and will be deprecated in Rubygems 4
-> SQLite.swift (0.11.6)
- ERROR | [iOS] unknown: Encountered an unknown error (Could not find a ios simulator (valid values: com.apple.coresimulator.simruntime.ios-10-0, com.apple.coresimulator.simruntime.ios-10-1, com.apple.coresimulator.simruntime.ios-10-2, com.apple.coresimulator.simruntime.ios-10-3, com.apple.coresimulator.simruntime.ios-11-0, com.apple.coresimulator.simruntime.ios-11-1, com.apple.coresimulator.simruntime.ios-11-2, com.apple.coresimulator.simruntime.ios-11-3, com.apple.coresimulator.simruntime.ios-11-4, com.apple.coresimulator.simruntime.ios-12-0, com.apple.coresimulator.simruntime.ios-12-1, com.apple.coresimulator.simruntime.ios-12-2, com.apple.coresimulator.simruntime.ios-8-1, com.apple.coresimulator.simruntime.ios-8-2, com.apple.coresimulator.simruntime.ios-8-3, com.apple.coresimulator.simruntime.ios-8-4, com.apple.coresimulator.simruntime.ios-9-0, com.apple.coresimulator.simruntime.ios-9-1, com.apple.coresimulator.simruntime.ios-9-2, com.apple.coresimulator.simruntime.ios-9-3, com.apple.coresimulator.simruntime.tvos-10-0, com.apple.coresimulator.simruntime.tvos-10-1, com.apple.coresimulator.simruntime.tvos-10-2, com.apple.coresimulator.simruntime.tvos-11-0, com.apple.coresimulator.simruntime.tvos-11-1, com.apple.coresimulator.simruntime.tvos-11-2, com.apple.coresimulator.simruntime.tvos-11-3, com.apple.coresimulator.simruntime.tvos-11-4, com.apple.coresimulator.simruntime.tvos-12-0, com.apple.coresimulator.simruntime.tvos-12-1, com.apple.coresimulator.simruntime.tvos-12-2, com.apple.coresimulator.simruntime.tvos-9-0, com.apple.coresimulator.simruntime.tvos-9-1, com.apple.coresimulator.simruntime.tvos-9-2, com.apple.coresimulator.simruntime.watchos-2-0, com.apple.coresimulator.simruntime.watchos-2-1, com.apple.coresimulator.simruntime.watchos-2-2, com.apple.coresimulator.simruntime.watchos-3-1, com.apple.coresimulator.simruntime.watchos-3-2, com.apple.coresimulator.simruntime.watchos-4-0, com.apple.coresimulator.simruntime.watchos-4-1, com.apple.coresimulator.simruntime.watchos-4-2, com.apple.coresimulator.simruntime.watchos-5-0, com.apple.coresimulator.simruntime.watchos-5-1, com.apple.coresimulator.simruntime.watchos-5-2). Ensure that Xcode -> Window -> Devices has at least one ios simulator listed or otherwise add one.

- Updated makefile iOS simulator to iPhone X
- Updated cocoapods version in gem file
@sburlewapg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

I found an issue on the CocoaPods repo that seems similar to what I'm experiencing. So I've updated the gem file to use v1.6.1 for cocoa pods, trying the tests again.

@sburlewapg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

One of the previously failing tests, VALIDATOR_SUBSPEC="none", is now passing, leaving three failing tests.

For VALIDATOR_SUBSPEC="standalone", does this error ring a bell @ypopovych, @timshadel?

-> Pod installation complete! There are 2 dependencies from the Podfile and 2 total pods installed.
Building with xcodebuild.
-> SQLite.swift/standalone (0.11.6)
- ERROR | [iOS] [SQLite.swift/standalone] unknown: Encountered an unknown error (419: unexpected token at '{
"availability" : "(available)",
"state" : "Shutdown",
"isAvailable" : true,
"name" : "iPad 2",
'

@ypopovych

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

Do we have iPad 2 in Xcode 10.2 at all?

@ypopovych

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

And I don't see changes in Gemfile.lock. I think you should run bundle update in CocoaPods tests folder, so it will update Gemfile.lock with latest gem versions (because you updated Gemfile, but Gemfile.lock has outdated versions)

@chasereed7

This comment has been minimized.

Copy link

commented Apr 11, 2019

this is completely out of my realm of competence, but I have a lot of code that relies on this pod. A few things I saw that that may (or many not) be helpful in your check errors:

copies from your details

//maybe an issue with older platform?

Running:

SQLite.swift/standard (0.11.6) - Analyzing on iOS 8.0 platform.

Preparing

// saw multiple lines similar to this
warning: ignoring duplicated output file: '/Users/travis/Library/Developer/Xcode/DerivedData/App-cfqygywpxtxfqaffiwimaaygvvbm/Build/Products/Debug/SQLite.swift-Unit-standard-tests.xctest/Contents/Resources/encrypted-4.x.sqlite' in shell script build phase '[CP] Copy Pods Resources'. This warning represents an extremely serious project misconfiguration and will likely cause some shell scripts in your project to be skipped entirely, leading to other build failures or missing files in the build directory. This will be a hard error in the future. (in target 'SQLite.swift-Unit-standard-tests')

@karishmapujara

This comment has been minimized.

Copy link

commented Apr 12, 2019

Please @stephencelis @ypopovych @sburlewapg release this pod for Swift 5.

@timshadel

This comment has been minimized.

Copy link

commented Apr 18, 2019

@sburlewapg I got it working after grabbing all your changes. There’s a ridiculously odd Xcode 10.2 bug (on clean installs like Travis) that’s causing the problem and it’s “solved” with using mkdir of all things. I tried to PR into your repo, but can’t. You can see my changes here:

https://github.com/timshadel/SQLite.swift/tree/swift5

@palpatim palpatim referenced this pull request Apr 18, 2019
@palpatim

This comment has been minimized.

Copy link

commented Apr 19, 2019

@stephencelis @ypopovych @sburlewapg: Is there an ETA for pulling in @timshadel's workaround and unblocking the release? We're trying to decide whether to fork this module from master into our project or wait for the 0.11.6 release to be completed.

@sburlewapg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

@timshadel That's a super weird issue! Thanks so much for looking into it. I'll pull in those changes and update the PR. @palpatim My hope is to have this PR ready today if the aforementioned changes get the remaining tests to pass. From there, I think @ypopovych can merge the PR into master? Do we need @stephencelis to release the update in CocoaPods or anything?

sburlewapg added some commits Apr 19, 2019

@sburlewapg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

@ypopovych the Travis tests have all passed! Is there anything else I need to do, or can you merge this into master and start releasing 0.11.6? Once this is merged, I'll submit another PR with Swift 5 so version 0.12 can follow quickly.

@stephencelis stephencelis merged commit 1a908a7 into stephencelis:master Apr 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stephencelis

This comment has been minimized.

Copy link
Owner

commented Apr 19, 2019

Thanks for the PR, @sburlewapg! I've added you as a collaborator.

@ypopovych

This comment has been minimized.

Copy link
Collaborator

commented Apr 20, 2019

@stephencelis @jberkel can you publish a new version to the CocoaPods repo? We don't have access to it.

@palpatim

This comment has been minimized.

Copy link

commented Apr 23, 2019

@stephencelis Do you have an ETA on pushing the updated podspec to CocoaPods trunk?

[Update 23-Apr] It looks like this has been pushed--at least, my CocoaPods projects that reference 0.11.6 are building without complaint--so I'm assuming this is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.