Version 0.12 (Swift 5) #913
Conversation
|
@stephencelis I don't suppose you'd have time for one more PR merge & version release? 🙏 |
|
@stephencelis please release for Swift 5 |
|
Is swift 4.2 version can be compiled with Swift5? |
|
Also, @sburlewapg, can you please add comment into README, that for Swift 4 "0.11" version should be used |
- Updated README to clarify Swift 5 vs Swift 4.2 supported versions - Updated minimum CocoaPods version - Updated SPM language versions
|
@ypopovych done. Let me know if you prefer any changes to that README note. |
|
Can you also update |
- Updated swift tools version in Package.swift - Updated "OS X" references to "macOS"
|
@ypopovych done. @stephencelis could I bother you for a review & merge for this PR once Travis finishes, or is there another person I should reach out to who can do that? |
stephencelis
left a comment
stephencelis
left a comment
There was a problem hiding this comment.
@sburlewapg Just a coupla small things!
|
@sburlewapg (I think it's also totally fine to not make the exact changes I've suggested, but we should ensure that the SwiftPM tests still pass on CI before merging.) |
@ypopovych I think we want to keep the tools version as a sort of minimum compiler deployment version. |
Co-Authored-By: sburlewapg <49003548+sburlewapg@users.noreply.github.com>
|
@stephencelis I totally agree, and I'm fine with bringing your suggested changes into the PR to make sure that all of the tests are happy. |
Co-Authored-By: sburlewapg <49003548+sburlewapg@users.noreply.github.com>
|
@stephencelis looks like the tests all pass! Good to go whenever you are. |
|
Tell me, please, is it possible to somehow install the new version using CocoaPods? |
|
@antileks this PR has to be merged first, and then somebody needs to release the new pod version. |
|
I think we can merge it. |
|
@ypopovych Thank you! Are you also able to push the new version to CocoaPods? |
5 participants
This updates the project to Swift 5, and also updates the iOS simulator to iPhone XS.