Permalink
Commits on Oct 12, 2016
Commits on Jul 3, 2016
  1. Merge pull request #313 from davidcelis/locking-and-unlocking

    Add `ghi lock` and `ghi unlock` commands
    committed on GitHub Jul 3, 2016
Commits on Jun 22, 2016
  1. Add `ghi lock` and `ghi unlock` commands

    A while back, I [added support for locking and unlocking issues via the
    API](https://developer.github.com/changes/2016-02-11-issue-locking-api/).
    This underwent a lengthy preview period that, as of today, [is
    over](https://developer.github.com/changes/2016-06-22-issue-locking-api-is-now-official/).
    
    With the preview media type no longer required in the `Accept` header, I
    thought I'd go ahead and quickly add the commands `ghi lock` and `ghi
    unlock`. These are both fairly straightforward commands, though I did
    keep the `-m` option that's also present on `ghi close` to provide a
    comment before locking (or unlocking) the given issue.
    
    Signed-off-by: David Celis <me@davidcel.is>
    davidcelis committed Jun 22, 2016
Commits on May 18, 2016
  1. List issues by milestone (#301)

    * Add --by-milestone flag
    
    * Extract milestones correctly
    
     - Reuse format_issues method
    davidCarlos committed with AlexChesters May 18, 2016
Commits on May 17, 2016
  1. Merge pull request #297 from shubhamshuklaer/check_if_proxy_nil

    Check if proxy_uri is nil before parsing
    committed May 17, 2016
  2. Merge pull request #300 from shubhamshuklaer/handle_repo_renaming

    Handle case when repo is renamed but upstream url not updated
    committed May 17, 2016
  3. Merge pull request #298 from shubhamshuklaer/fix_show_output

    Check if its a pull request using i.key?('pull_request')
    committed May 17, 2016
  4. Handle case when repo is renamed but upstream url not updated

    When repo is renamed and we use the old url for api call, the response
    is Net::HTTPTemporaryRedirect and it contains the currosponding new url.
    shubhamshuklaer committed May 16, 2016
Commits on May 14, 2016
  1. Check if proxy_uri is nil before parsing

    URI.parse is able to handle empty string("") as uri but not nil.
    shubhamshuklaer committed May 13, 2016
Commits on May 13, 2016
Commits on May 6, 2016
  1. Merge pull request #294 from davidcelis/add-suffix-to-warning

    Fix GitHub repo warning
    committed May 6, 2016
  2. Fix GitHub repo warning

    Signed-off-by: David Celis <me@davidcel.is>
    davidcelis committed May 6, 2016
  3. Merge pull request #293 from davidcelis/add-suffix-to-warning

    Add [ -- [<user>/]<repo> ] suffix to warning
    committed May 6, 2016
  4. Add [ -- [<user>/]<repo> ] suffix to warning

    In #279, a user expressed confusion that `[ -- [<user>/]<repo> ]` as a
    command suffix is actually global and can be used with any command. This
    patch adds a helpful message to the warning "Not a GitHub repo" to
    suggest either re-running the command from a GitHub repo, or using the
    suffix.
    
    Fixes #279.
    
    Signed-off-by: David Celis <me@davidcel.is>
    davidcelis committed May 6, 2016
  5. Merge pull request #292 from davidcelis/no-content-type

    Use application/vnd.github.v3+json
    committed May 6, 2016
  6. Use application/vnd.github.v3+json

    The `application/vnd.github.beta+json` media type has been
    [deprecated](https://developer.github.com/v3/versions/) for quite some
    time. It's recommended that the actual API version, v3, be used instead.
    
    This had only a minor impact to GHI: in v3, the `"pull_request"` key of
    an issue response is omitted for issues that are not also pull requests.
    Previously, `"pull_request"` would still be present but empty.
    
    Signed-off-by: David Celis <me@davidcel.is>
    davidcelis committed May 6, 2016
Commits on Apr 21, 2016
  1. Merge pull request #284 from shubhamshuklaer/master

    Add support for proxy authentication
    committed Apr 21, 2016
  2. Merge pull request #286 from shubhamshuklaer/editor_syntax_highlight

    Change file extension of temperory files to md
    committed Apr 21, 2016
  3. Merge pull request #287 from shubhamshuklaer/markdown_style_comments

    Use markdown style comments for trailing message
    committed Apr 21, 2016
Commits on Apr 20, 2016
  1. Bump version to 1.2.0 #285

    AlexChesters committed Apr 19, 2016
Commits on Apr 18, 2016
  1. Append .md to filename used for comment after comment id

    Fix error introduced in commit 8a7a195, where while amending comment,
    the file name is of the form GHI_COMMENT_[issue_number].md_[comment_identifier]
    shubhamshuklaer committed Apr 18, 2016
Commits on Apr 17, 2016
  1. Change file extension of temperory files to md

    Change the file extension of temporary files used for creating/editing
    issues,comments and milestones to md(markdown).  The editor will
    recoganize that its a markdown file and use markdown syntax
    highlighting.
    shubhamshuklaer committed Apr 17, 2016
Commits on Apr 8, 2016
  1. Merge pull request #282 from davidcelis/fix-parsing

    Fix uncaught LoadError requiring pygments.rb
    committed Apr 8, 2016
  2. Fix uncaught LoadError requiring pygments.rb

    If `ghi` was installed via Homebrew before pygments.rb was added as a
    dependency, the check for pygments being installed never gets run. It
    looks like there was intention to rescue that `require` statement but
    because `LoadError` doesn't inherit from `StandardError`, the exception
    was uncaught and `ghi` would silently exit. This only seems to happen
    currently on issues that include fenced code blocks, but I provided
    reproducible evidence in #281. Merging this will fix #281, but I have
    two concerns about the fact that pygments.rb was included as a
    dependency in the first place:
    
    1. Homebrew doesn't install Ruby gems for you, so this has to be done
       manually. Attempting to `brew install ghi` without first having run
       `gem install pygments.rb` just outputs an error and doesn't finish.
    2. Most Ruby developers install several versions of Ruby using a version
       manager like rvm, rbenv, or chruby. You can `gem install pygments.rb`
       on one version of Ruby (or `sudo gem install pygments.rb` on the
       system version of Ruby, which is a whole other problem) but as soon
       as you try to use `ghi` after switching Rubies, you have to remember
       to install `pygments.rb`. This isn't great.
    
    I see two solutions here. We can either no longer offer a Homebrew
    formula, instead urging users to just install via `gem install ghi` or
    we can remove pygments.rb as a dependency. Personally I think `ghi`
    should try to remain free of dependencies for this reason, but I leave
    it in your hands.
    
    Signed-off-by: David Celis <me@davidcel.is>
    davidcelis committed Apr 8, 2016
  3. Merge pull request #280 from davidcelis/no-labels

    Add --no-labels option to `ghi-list`
    committed Apr 8, 2016
  4. Add --no-labels option to `ghi-list`

    There have been a few requests for an option to prevent printing labels
    when listing issues. If the list of issues involves a lot of labels, it
    leads to truncation of issue titles. To make it easier to visually parse
    lists like this, I've added a `--no-labels` option to `ghi-list` to
    skip printing labels in the pager. Closes #259.
    
    Signed-off-by: David Celis <me@davidcel.is>
    davidcelis committed Apr 8, 2016
Commits on Mar 4, 2016
  1. Merge pull request #278 from stephencelis/remove_json_pure

    Remove json pure #277
    AlexChesters committed Mar 4, 2016
  2. #277 Remove json-pure

    AlexChesters committed Mar 4, 2016
  3. Update .gitignore

    AlexChesters committed Mar 4, 2016
Commits on Feb 26, 2016
  1. Bump version to 1.1.1

    AlexChesters committed Feb 26, 2016
Commits on Feb 11, 2016
  1. Update README

    AlexChesters committed Feb 11, 2016