Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event List empty #432

Closed
olesq opened this issue Mar 13, 2018 · 8 comments

Comments

@olesq
Copy link

commented Mar 13, 2018

Event List showing as empty for editing purposes although all events displaying as normal in calendar etc. Total of events showing correctly at top of page. Seems to have happened since 'group by' fix.
WP-eventlist.docx

@stephenharris

This comment has been minimized.

Copy link
Owner

commented Mar 13, 2018

Hi @olesq would you be able to install the Query Monitor plugin ( https://en-gb.wordpress.org/plugins/query-monitor/) and leave a comment here with the main SQL query for events (involving eo_events table)?

I've not been able to replicate this issue, so I'm wondering if its down to a MySQL version, plugin configuration or a conflict with another plugin.

@olesq

This comment has been minimized.

Copy link
Author

commented Mar 14, 2018

@stephenharris

This comment has been minimized.

Copy link
Owner

commented Mar 14, 2018

@olesq I don't think attachments work when replying by email. You can upload the image by visiting this issue in a web browser.

@olesq

This comment has been minimized.

Copy link
Author

commented Mar 14, 2018

Here is screen print of output from Query Monitor
WP-eventlist-QM-eo-events-join.docx

@stephenharris

This comment has been minimized.

Copy link
Owner

commented Mar 14, 2018

Thanks @olesq - that's helped a lot in getting to the bottom of this. The fix for #430 was to join the table against itself which results in a (potential) N^2 join where N is the number of rows in the eo_events table. If you have enough rows that is set larger than you SQL server's MAX_JOIN_SIZE then you'll get this error.

The solution is two fold - first, the plug-in will explicitly tell the MySQL server that 'big joins are ok' (SET SQL_BIG_SELECTS=1;). It will then ignore the MAX_JOIN_SIZE limit, and fix the immediate issue.

The MAX_JOIN_SIZE is there to prevent applications from crashing because they run a join too large for the mysql server to handle. Therefore, the second change is that the admin event list page will run a different query when grouping the event dates; a more efficient one, which is possible because it doesn't matter how it groups the dates.

Therefore, out of the box the plug-in won't run the (potentially) large JOIN query, and will do only when 'grouping occurrences' in the settings page, or shortcode/widget settings - is enabled.

There'll be an update in the next few days - if you are able to test fix ahead of that release, I would be very grateful.

@olesq

This comment has been minimized.

Copy link
Author

commented Mar 15, 2018

@olesq

This comment has been minimized.

Copy link
Author

commented Mar 21, 2018

@stephenharris

This comment has been minimized.

Copy link
Owner

commented Mar 26, 2018

HI @olesq sorry for the delay - that should be released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.