Abort task on error #4

Merged
merged 2 commits into from Mar 30, 2015

Conversation

Projects
None yet
4 participants
@alexVauch
Contributor

alexVauch commented Oct 16, 2014

Hello. it's better to abort task on text domain errors. It is necessary when using batch of tasks.

@Aetles

This comment has been minimized.

Show comment
Hide comment
@Aetles

Aetles Oct 16, 2014

Why remove the commas? Having them there makes it easier to cut and paste lines without having to adjust commas and reduces risk of missing comma errors. Like the Grunt example code here, all trailing commas: http://gruntjs.com/configuring-tasks

Aetles commented Oct 16, 2014

Why remove the commas? Having them there makes it easier to cut and paste lines without having to adjust commas and reduces risk of missing comma errors. Like the Grunt example code here, all trailing commas: http://gruntjs.com/configuring-tasks

@alexVauch

This comment has been minimized.

Show comment
Hide comment
@alexVauch

alexVauch Oct 16, 2014

Contributor

You are right. JSHint throws an error. But it is related for browser environment.

Contributor

alexVauch commented Oct 16, 2014

You are right. JSHint throws an error. But it is related for browser environment.

@alexVauch alexVauch changed the title from Feature to Abort task on text domain error Oct 16, 2014

@alexVauch alexVauch changed the title from Abort task on text domain error to Abort task on error Oct 16, 2014

@fxbenard

This comment has been minimized.

Show comment
Hide comment
@fxbenard

fxbenard Mar 6, 2015

What about this PR - Nice improvement

fxbenard commented Mar 6, 2015

What about this PR - Nice improvement

@stephenharris

This comment has been minimized.

Show comment
Hide comment
@stephenharris

stephenharris Mar 30, 2015

Owner

Agreed :), apologies for the delay in acting on this on. Thanks @alexVauch & @Aetles

Owner

stephenharris commented Mar 30, 2015

Agreed :), apologies for the delay in acting on this on. Thanks @alexVauch & @Aetles

stephenharris added a commit that referenced this pull request Mar 30, 2015

Merge pull request #4 from alexVauch/feature
Abort task on error. Props to @alexVauch.

@stephenharris stephenharris merged commit 666f1e9 into stephenharris:master Mar 30, 2015

@stephenharris

This comment has been minimized.

Show comment
Hide comment
@stephenharris

stephenharris Mar 30, 2015

Owner

Published. I've also added a force option to toggle this behaviour.

Owner

stephenharris commented Mar 30, 2015

Published. I've also added a force option to toggle this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment