New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --add-location parameter #16

Merged
merged 1 commit into from Aug 9, 2016

Conversation

Projects
None yet
2 participants
@TimVevida
Contributor

TimVevida commented Jul 6, 2016

Allow usage of the --add-location parameter. By default, the location
consists of a hash, colon, file name and line number. In more recent
versions of xgettext, this can be altered to 'none' or 'file'. The
default value is 'full', but this is implied when the parameter is
missing.

I want to remove the line numbers from the .pot-file, because they
change frequently and this causes differences in the .pot-file that are
not really changes, but do show op in the versioning system each time.

Allow --add-location parameter
Allow usage of the --add-location parameter. By default, the location
consists of a hash, colon, file name and line number. In more recent
versions of xgettext, this can be altered to 'none' or 'file'. The
default value is 'full', but this is implied when the parameter is
missing.

I want to remove the line numbers from the .pot-file, because they
change frequently and this causes differences in the .pot-file that are
not really changes, but do show op in the versioning system each time.
@TimVevida

This comment has been minimized.

Show comment
Hide comment
@TimVevida

TimVevida Jul 28, 2016

Contributor

@stephenharris Please accept this PR or comment on it.

Contributor

TimVevida commented Jul 28, 2016

@stephenharris Please accept this PR or comment on it.

@stephenharris

This comment has been minimized.

Show comment
Hide comment
@stephenharris

stephenharris Jul 29, 2016

Owner

Thanks Tim. I think we should aim to keep the default behavior. This looks like it changes that to not adding a location. Is that right?

What happens if the argument is applied to older versions of xgettext? Is it just ignored or does it throw an error?

Owner

stephenharris commented on c4b3379 Jul 29, 2016

Thanks Tim. I think we should aim to keep the default behavior. This looks like it changes that to not adding a location. Is that right?

What happens if the argument is applied to older versions of xgettext? Is it just ignored or does it throw an error?

@TimVevida

This comment has been minimized.

Show comment
Hide comment
@TimVevida

TimVevida Aug 9, 2016

Contributor

Hello Stephen, thanks for responding.

To answer your first question: By default, the --add-location argument will not be added to the xgettext call. This ensures compatibility with existing configurations.

I know that the --add-location argument was added at some point, but cannot find a changelog of xgettext. So I could not tell you what would happen for older versions of xgettext. I presume they will give an error.

Contributor

TimVevida commented Aug 9, 2016

Hello Stephen, thanks for responding.

To answer your first question: By default, the --add-location argument will not be added to the xgettext call. This ensures compatibility with existing configurations.

I know that the --add-location argument was added at some point, but cannot find a changelog of xgettext. So I could not tell you what would happen for older versions of xgettext. I presume they will give an error.

@stephenharris stephenharris merged commit bc53e72 into stephenharris:master Aug 9, 2016

@stephenharris

This comment has been minimized.

Show comment
Hide comment
@stephenharris

stephenharris Aug 9, 2016

Owner

Ah, of course, not sure how I missed that. Thanks for the PR!

Owner

stephenharris commented Aug 9, 2016

Ah, of course, not sure how I missed that. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment