New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on Windows #148

Merged
merged 2 commits into from Mar 5, 2012

Conversation

Projects
None yet
2 participants
@ctrengove
Contributor

ctrengove commented Mar 5, 2012

Three things to fix:

  • rmtree() needs a Unicode path because of the Unicode characters in some of the image names;
  • need to convert to backslashes when comparing file names;
  • image must be closed before it can be deleted.

With these changes, all 271 tests pass. Hopefully they still pass on other platforms as well!

@stephenmcd

This comment has been minimized.

Show comment
Hide comment
@stephenmcd

stephenmcd Mar 5, 2012

Owner

Yep all tests still pass - thank you.

Owner

stephenmcd commented Mar 5, 2012

Yep all tests still pass - thank you.

@stephenmcd stephenmcd merged commit 1c41de7 into stephenmcd:master Mar 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment