Add `reversion_compare` compatabilbty. #605

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@pahaz
Contributor

pahaz commented Mar 20, 2013

No description provided.

@stephenmcd

This comment has been minimized.

Show comment Hide comment
@stephenmcd

stephenmcd Mar 22, 2013

Owner

I'm not sure if we want to start including a bunch of code in Mezzanine particularly to support reversion. I've started a discussion for this on the mailing list:

https://groups.google.com/group/mezzanine-users/browse_thread/thread/158fdc019dfa30d7

Owner

stephenmcd commented Mar 22, 2013

I'm not sure if we want to start including a bunch of code in Mezzanine particularly to support reversion. I've started a discussion for this on the mailing list:

https://groups.google.com/group/mezzanine-users/browse_thread/thread/158fdc019dfa30d7

@stephenmcd

This comment has been minimized.

Show comment Hide comment
@stephenmcd

stephenmcd Apr 1, 2013

Owner

We've actually removed the USE_REVERSION setting in the latest version. There were several areas where it still didn't function correctly.

Your contributions started working towards correcting some of these (thank you), but it's clear that we would have needed to add more and more code into Mezzanine itself for this to be a complete solution, which I think is the wrong approach.

What we should be able to do is get it to work by simply unregistering admin classes and registering custom classes from within your own project (that include reversion compatibility). Perhaps this would make for a good separate app called mezzanine-reversion, which includes everything needed to get this to work. Would you be interested in working on something like that?

I'm going to close these pull requests for now. Thanks again.

Owner

stephenmcd commented Apr 1, 2013

We've actually removed the USE_REVERSION setting in the latest version. There were several areas where it still didn't function correctly.

Your contributions started working towards correcting some of these (thank you), but it's clear that we would have needed to add more and more code into Mezzanine itself for this to be a complete solution, which I think is the wrong approach.

What we should be able to do is get it to work by simply unregistering admin classes and registering custom classes from within your own project (that include reversion compatibility). Perhaps this would make for a good separate app called mezzanine-reversion, which includes everything needed to get this to work. Would you be interested in working on something like that?

I'm going to close these pull requests for now. Thanks again.

@stephenmcd stephenmcd closed this Apr 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment