added stricter typing for country prop #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenway
approved these changes
Apr 6, 2022
Owner
stephenway
left a comment
stephenway
left a comment
There was a problem hiding this comment.
This is awesome, thanks @morellodev!
stephenway
added a commit
that referenced
this pull request
Apr 27, 2022
added stricter typing for country prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the
countryprop is typed asstring, while the set of legal country codes is limited.We can leverage the
countryCodesarray to build up aCountryCodetype that we can use to better type thecountryprop. Moreover, we can export it for external usage.Note that the proposed solution is not breaking for existing codebases (we loosely type
countryto be of typeCountryCode | Omit<string, CountryCode>).