Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access to the root FS from lua #2184

Merged
merged 2 commits into from Feb 6, 2022

Conversation

natano
Copy link
Contributor

@natano natano commented Feb 6, 2022

On linux / is mounted to /rootfs in RageFile, which allows access to the whole filesystem from lua. This means themes and mod files can re-write user data and extract files via USB profiles.

/rootfs was only added for internal use by the alsa, oss and memory card drivers, so it can be easily replaced with direct fstream file access.

On linux / is mounted to /rootfs in RageFile, which allows access to the
_whole_ filesystem from lua. This means themes and mod files can
re-write user data and extract files via USB profiles.

/rootfs was only added for internal use by the alsa, oss and memory card
drivers, so it can be easily replaced with direct fstream file access.
@Scraticus Scraticus merged commit 2de4273 into stepmania:5_1-new Feb 6, 2022
4 of 5 checks passed
@Scraticus
Copy link
Member

Good spot, this behaviour hasn't been needed in a very very long time. Will also port to OF, thanks for reporting!

@natano natano deleted the sm-remove-rootfs branch February 6, 2022 16:17
poco0317 added a commit to etternagame/etterna that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants