Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

remove Class::MOP::load_class #33

Merged
merged 1 commit into from Feb 2, 2014

Conversation

Projects
None yet
3 participants
Contributor

xenoterracide commented Dec 14, 2013

use of load_class is deprecated within Moose, removing entirely in favor of
Module::Runtime

Signed-off-by: Caleb Cushing xenoterracide@gmail.com

Collaborator

doy commented Dec 14, 2013

This doesn't seem to pass the test suite.

Contributor

xenoterracide commented Dec 14, 2013

Files=63, Tests=746, 14 wallclock secs ( 0.27 usr  0.06 sys + 51.15 cusr  1.67 csys = 53.15 CPU)
Result: PASS
[DZ] all's well; removing .build/gYAdmgbCkH

all tests pass on my system, an no warnings are thrown with the current devel Moose, could you please provide information about what tests it doesn't pass? and perhaps some clues as to environmental differences that may affect this.

Collaborator

doy commented Dec 14, 2013

Well, travis isn't passing.

Contributor

xenoterracide commented Dec 14, 2013

ok, something about the new moose changes something more so that the test suite passes... I wonder what...

remove Class::MOP::load_class
use of load_class is deprecated within Moose, removing entirely in favor of
Module::Runtime

Signed-off-by: Caleb Cushing <xenoterracide@gmail.com>
Contributor

xenoterracide commented Dec 14, 2013

ok, fixed, entirely has to do with the inline class problem, other solutions to this are available too (such as using Class::Load::load_class, or modifying the test suite to modify %INC )

wayan commented Feb 2, 2014

Anything new with this issue? I would also like to get rid of those long deprecation warnings about Class::MOP::class_load in Bread::Board.

doy added a commit that referenced this pull request Feb 2, 2014

@doy doy merged commit 0bda466 into stevan:master Feb 2, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment