New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Content-Disposition via stash options #2

Merged
merged 1 commit into from Jan 12, 2015

Conversation

Projects
None yet
3 participants
@kaoru
Contributor

kaoru commented Jan 10, 2015

Setting $c->stash->{excel_disposition} to a string will set that for the
Content-Disposition header. The default is "inline".

Setting $c->stash->{excel_filename} will set the filename appropriately
in the Content-Disposition header. The default is "excel.xls".


https://rt.cpan.org/Ticket/Display.html?id=68918

Add support for Content-Disposition via stash options
Setting $c->stash->{excel_disposition} to a string will set that for the
Content-Disposition header. The default is "inline".

Setting $c->stash->{excel_filename} will set the filename appropriately
in the Content-Disposition header. The default is "excel.xls".

stevan added a commit that referenced this pull request Jan 12, 2015

Merge pull request #2 from kaoru/rt-68918-content-disposition-and-exc…
…el-filename

Add support for Content-Disposition via stash options

@stevan stevan merged commit 9a1e0e9 into stevan:master Jan 12, 2015

@stevan

This comment has been minimized.

Show comment
Hide comment
@stevan

stevan Jan 12, 2015

Owner

Thanks for this patch as well, ... sometime this week it will be on CPAN, thanks!

Owner

stevan commented Jan 12, 2015

Thanks for this patch as well, ... sometime this week it will be on CPAN, thanks!

@kaoru

This comment has been minimized.

Show comment
Hide comment
@kaoru

kaoru Jan 12, 2015

Contributor

Awesome, pleasure working with you Stevan :-) Once it's live please go ahead and update the ticket on RT here: https://rt.cpan.org/Ticket/Display.html?id=68918

If you have any ideas for the other open ticket on RT I'd be happy to build another patch, but I don't have a good test case for what Jorge's trying to do. https://rt.cpan.org/Ticket/Display.html?id=68917

Thanks!

Contributor

kaoru commented Jan 12, 2015

Awesome, pleasure working with you Stevan :-) Once it's live please go ahead and update the ticket on RT here: https://rt.cpan.org/Ticket/Display.html?id=68918

If you have any ideas for the other open ticket on RT I'd be happy to build another patch, but I don't have a good test case for what Jorge's trying to do. https://rt.cpan.org/Ticket/Display.html?id=68917

Thanks!

@stevan

This comment has been minimized.

Show comment
Hide comment
@stevan

stevan Jan 13, 2015

Owner

@rbo looks like there is a permissions issue on CPAN, can you give me permissions for the Catalyst::Helper::View::Excel::Template::Plus namespace please?

Owner

stevan commented Jan 13, 2015

@rbo looks like there is a permissions issue on CPAN, can you give me permissions for the Catalyst::Helper::View::Excel::Template::Plus namespace please?

@rbo

This comment has been minimized.

Show comment
Hide comment
@rbo

rbo Jan 13, 2015

Collaborator

@stevan, I added you as co-maint. Have fun and thank you for support!

Collaborator

rbo commented Jan 13, 2015

@stevan, I added you as co-maint. Have fun and thank you for support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment