New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves merge conflist for PR #22 and add a few tests #23

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@lharey
Contributor

lharey commented Sep 21, 2017

Hi

As per our emails re the PR request challenge. This resolves the merge conflict for PR #22.
I have also added a few more tests. If these tests are the kind of thing you were after then if I get chance next week I may be able to add some more.

@stevan

This comment has been minimized.

Show comment
Hide comment
@stevan

stevan Dec 11, 2017

Owner

All merged and looking good, thanks for this, and sorry it took so long to merge.

Owner

stevan commented Dec 11, 2017

All merged and looking good, thanks for this, and sorry it took so long to merge.

@stevan stevan closed this Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment