Socket disabled by default #102

Closed
WheresAlice opened this Issue May 2, 2011 · 5 comments

Comments

Projects
None yet
4 participants

In commit e5f2cc2 Sockets and SampleRateConverter are disabled by default in order to make enable building on BSD by @ckeen . This is bound to cause confusion, and we should enable them by default on operating systems where they compile cleanly.

Since I do not have a BSD compatible machine I can't test this, but I believe that we can easily include these libraries for Linux distros by checking

if(${CMAKE_SYSTEM_NAME} MATCHES "(Linux)")

as well as which ever other distros Sockets compiles cleanly on.

Contributor

jeremytregunna commented May 31, 2011

Someone clearly is missing the point with this, disabling Socket is the WRONG thing to do, and I vote that code be removed. The solution to the problem is to update the Socket addon to use libevent2's API instead of requiring libevent 1.4.2. Who wants to chip in and get this done?

Contributor

ckeen commented Jun 2, 2011

I agree. Back then I did not expect this to get merged into the main tree at all.

Contributor

jeremytregunna commented Jun 2, 2011

Helpful hint in the future, use "git add -p" to selectively add modifications then commit without -a. Helps you avoid sending in bits you don't want to be. :)

Sent from my iPhone

On 2011-06-02, at 11:15, ckeenreply@reply.github.com wrote:

I agree. Back then I did not expect this to get merged into the main tree at all.

Reply to this email directly or view it on GitHub:
#102 (comment)

Contributor

ckeen commented Jun 2, 2011

I know this. I have disabled the sockets on my tree as it was broken and I wanted to fix the build system first.
Steve then merged the whole tree.

Contributor

jeremytregunna commented Jun 2, 2011

Ah ok. Yeah he does that sometimes. I have learned to do my dev in a separate branch leaving master for Steve to go speshit on. :)

Sent from my iPhone

On 2011-06-02, at 11:21, ckeenreply@reply.github.com wrote:

I know this. I have disabled the sockets on my tree as it was broken and I wanted to fix the build system first.
Steve then merged the whole tree.

Reply to this email directly or view it on GitHub:
#102 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment