Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join forks code into (this) main repo #3

Open
falkTX opened this issue Nov 24, 2017 · 3 comments
Open

Join forks code into (this) main repo #3

falkTX opened this issue Nov 24, 2017 · 3 comments

Comments

@falkTX
Copy link

falkTX commented Nov 24, 2017

There are currently 2 forks of SFZero which provide useful new features.
https://github.com/schellingb/SFZero
https://github.com/jamiebullock/SFZero

Would be nice to get everything together in 1 repo, so we don't have to choose between features.

I would rather submit bugs against the forks, to request a PR from them, but they have closed the reporting of bugs :(

@falkTX
Copy link
Author

falkTX commented Nov 24, 2017

Will you accept a PR that incorporates the useful changes from those repos?
I could do this, eventually...

@simonvanderveldt
Copy link

It might be useful to ping @schellingb and @jamiebullock for this?

@jamiebullock
Copy link

@falkTX @simonvanderveldt Sorry, I've only just seen this, for some reason I missed the notification.

I think merging forks would be a good idea, but it needs some care. I'm also not sure if @stevefolta is interested in continuing to work on this, review and merge PRs etc. It might be better if one of the downstream repos became the official one.

Anyhow, I've opened the issue tracker on my fork if you want to report bugs there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants