New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Phoenix 1.4 馃帀 #29

Merged
merged 3 commits into from Nov 8, 2018

Conversation

Projects
None yet
1 participant
@stevegrossi
Owner

stevegrossi commented Nov 5, 2018

Pretty easy thanks to this great gist from Chris McCord. Though I had some trouble with the (optional) Brunch -> Webpack transition, which I'll save for a follow-up.

Upgrade to Phoenix 1.4
- replace `render(SessionView, 鈥)` with `put_view`
@@ -22,6 +22,8 @@ config :logger, :console,
format: "$time $metadata[$level] $message\n",
metadata: [:request_id]
config :phoenix, :json_library, Jason

This comment has been minimized.

@stevegrossi

stevegrossi Nov 6, 2018

Owner

What could possibly go wrong?

def exists?(queryable) do
count(queryable) > 0
end

This comment has been minimized.

@stevegrossi

stevegrossi Nov 6, 2018

Owner

Now part of Ecto! 馃帀

(And they implemented it more efficiently than I did...)

{:credo, "~> 0.8.6", only: :dev},
{:ex_machina, "~> 2.1.0", only: :test},
{:ex_machina, "~> 2.2", only: :test},

This comment has been minimized.

@stevegrossi stevegrossi merged commit 49cb731 into master Nov 8, 2018

2 checks passed

continuous-integration/codeship Build succeeded
Details
ebert Ebert did not find any new or fixed issues.
Details

@stevegrossi stevegrossi deleted the stevegrossi/phoenix-1-4 branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment