Extract a database view for streaks to enable simpler and more powerful querying #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SO COOL that you can base schemas off of database views just like tables Begone, raw SQL!
stevegrossi
commented
Jan 12, 2017
| habit | ||
| |> assoc(:streaks) | ||
| |> where([s], s.end >= ^Habits.Date.yesterday) | ||
| |> select([s], s.length) |
There was a problem hiding this comment.
I thought the binding syntax (used here) would be equivalent with the bindingless syntax, e.g.
|> select([:length])but they return different results. The binding syntax returns the bare value of the selected column, while the bindingless syntax returns an entire %Streak{} struct with only the selected attribute present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I❤️ ❤️ ❤️ how you can build Ecto schemas on top of database views just like you can with tables. This let me push the data logic for streaks down into the database and allow a much simpler querying syntax (no raw SQL) in the Elixir code. A refactor of the streaks query also enabled richer querying, such as for the longest streak as well as the current one: