Steve Hodgkiss stevehodgkiss

Organizations

Envato Guard
stevehodgkiss commented on pull request envato/zxcvbn-ruby#10
Steve Hodgkiss

This is great, thanks Tim! I've released 0.0.3 with these changes.

Steve Hodgkiss
Steve Hodgkiss
stevehodgkiss merged pull request envato/zxcvbn-ruby#10
Steve Hodgkiss
Reduce load time, memory allocations and retained memory
3 commits with 85,103 additions and 85,104 deletions
Steve Hodgkiss
Steve Hodgkiss
Steve Hodgkiss
Steve Hodgkiss
stevehodgkiss commented on pull request rack/rack-contrib#78
Steve Hodgkiss

Most proxies are configured to append to X-Forwarded-For, and the left most value can be client supplied. For example, if I curl -H 'X-Forwarded-Fo…

Steve Hodgkiss
  • Steve Hodgkiss c584386
    Use the correct method in readme
Steve Hodgkiss
Steve Hodgkiss
Steve Hodgkiss
Steve Hodgkiss
Steve Hodgkiss
stevehodgkiss commented on pull request rack/rack-contrib#78
Steve Hodgkiss

Regarding using X-Forwarded-For as the key for rate limiting: most proxies append to that header, and it's value can be changed by the client, so u…

Steve Hodgkiss
Steve Hodgkiss
  • Steve Hodgkiss ba5f1cb
    Update readme, remove args from failure method
Steve Hodgkiss
stevehodgkiss commented on issue lotus/controller#67
Steve Hodgkiss

@jodosha yes, that's what I had in mind, only mandatory if you're whitelisting (with a params block). @Emily if a developer doesn't want to coerce …

Steve Hodgkiss
  • Steve Hodgkiss 6daec19
    Add integration test for nested validations
Steve Hodgkiss
  • Steve Hodgkiss ba6e62f
    Put each assignment on its own line in Error#initialize
stevehodgkiss commented on pull request lotus/validations#46
Steve Hodgkiss

Yeah I would prefer these to be on one line too. Will update...

Steve Hodgkiss
  • Steve Hodgkiss 584fb26
    Be consistent and always return strings from attribute
Steve Hodgkiss
  • Steve Hodgkiss 5357fd1
    Let error handle namespaced logic
Steve Hodgkiss
  • Steve Hodgkiss 6c6ba3a
    Add integration test for nested validations
Steve Hodgkiss