New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependency #1

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
2 participants
@davidfowl
Contributor

davidfowl commented Aug 15, 2018

You don't need Microsoft.AspNetCore.Hosting.WindowsServices

@stevejgordon

Thanks @davidfowl. Left a question for you as now a little confused on the best option,

@@ -8,7 +8,7 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Hosting.WindowsServices" Version="2.1.1" />
<PackageReference Include="System.ServiceProcess.ServiceController" Version="4.5.0" />
<PackageReference Include="Microsoft.Extensions.Hosting" Version="2.1.1" />

This comment has been minimized.

@stevejgordon

stevejgordon Aug 16, 2018

Owner

Just realised that I can reduce to just

<ItemGroup>
     <PackageReference Include="Microsoft.AspNetCore.Hosting.WindowsServices" Version="2.1.1" />
  </ItemGroup>

which then brings in both Microsoft.Extensions.Hosting and System.ServiceProcess.ServiceController. Is there a benefit to pulling both in directly?

@stevejgordon

stevejgordon Aug 16, 2018

Owner

Just realised that I can reduce to just

<ItemGroup>
     <PackageReference Include="Microsoft.AspNetCore.Hosting.WindowsServices" Version="2.1.1" />
  </ItemGroup>

which then brings in both Microsoft.Extensions.Hosting and System.ServiceProcess.ServiceController. Is there a benefit to pulling both in directly?

This comment has been minimized.

@stevejgordon

stevejgordon Aug 16, 2018

Owner

Actually seems then I can't resolve HostBuilder, so potentially scratch this query while I check the package graph again!

@stevejgordon

stevejgordon Aug 16, 2018

Owner

Actually seems then I can't resolve HostBuilder, so potentially scratch this query while I check the package graph again!

This comment has been minimized.

@stevejgordon

stevejgordon Aug 16, 2018

Owner

Okay, yeah I see, brings in only Microsoft.Extensions.Hosting.Abstractions under Microsoft.AspNetCore.Hosting.

@stevejgordon

stevejgordon Aug 16, 2018

Owner

Okay, yeah I see, brings in only Microsoft.Extensions.Hosting.Abstractions under Microsoft.AspNetCore.Hosting.

@stevejgordon stevejgordon merged commit 9e78fb5 into stevejgordon:master Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment