Issue 3 #4
Merged
Issue 3 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue numbers for projects that have a hyphen. using more aggressive regexp
steveklabnik
added a commit
that referenced
this pull request
Jul 16, 2013
|
No, this looks great, thank you! Deploying now. |
|
confirmed that it worked on https://github.com/deanmalmgren/pr-test/pull/1. Thanks for merging and deploying so quickly! |
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is a fix for issue #3. I did two quick tests. One with a repository that did not have a hyphen and the issue2pr worked fine. When a hyphen was added to the repository name though, issue2pr did not work :(. This has to do with the regexp that is used to extract the username, project name, and issue number in the regular expression.
I'm not terribly familiar with sinatra so I'm not sure that my syntax is correct here. If I've bungled anything, let me know and I can add a quick patch.