Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upLibz blitz/turn references to other semver items int links #143
Conversation
muzikmoe
added some commits
Oct 25, 2017
This comment has been minimized.
This comment has been minimized.
KodrAus
commented
Oct 26, 2017
|
Thanks @muzikmoe! It'd be helpful if we could use separate branches for each of these PRs that's just based off master with the commit that fixes the issue. That way it'll be easier to review the code for the specific issue you're fixing :) Are you able to cherry pick commit We should do the same for the other PRs you've opened (thanks again for tackling these issues!) |
This comment has been minimized.
This comment has been minimized.
|
@KodrAus Thank for your guiding, I am sorry for bothering you with these formless pull requests.
|
This comment has been minimized.
This comment has been minimized.
KodrAus
commented
Oct 26, 2017
|
That's the one! And it's absolutely no problem or bother at all. We appreciate your contributions :) It'll just be easier down the track when @steveklabnik is ready for a look. |
muzikmoe
referenced this pull request
Oct 26, 2017
Closed
libz blitz: turn references to other semver items into links #145
This comment has been minimized.
This comment has been minimized.
|
rebased. |
muzikmoe commentedOct 26, 2017
Should resolve #132