Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libz blitz/turn references to other semver items int links #143

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
2 participants
@muzikmoe
Copy link
Contributor

muzikmoe commented Oct 26, 2017

Should resolve #132

muzikmoe added some commits Oct 25, 2017

@KodrAus

This comment has been minimized.

Copy link

KodrAus commented Oct 26, 2017

Thanks @muzikmoe!

It'd be helpful if we could use separate branches for each of these PRs that's just based off master with the commit that fixes the issue. That way it'll be easier to review the code for the specific issue you're fixing :)

Are you able to cherry pick commit 422230a onto a new branch that's based off master? I'm happy to guide you through it if you'd like a hand.

We should do the same for the other PRs you've opened (thanks again for tackling these issues!)

@muzikmoe

This comment has been minimized.

Copy link
Contributor Author

muzikmoe commented Oct 26, 2017

@KodrAus Thank for your guiding, I am sorry for bothering you with these formless pull requests.
If I get your point, do you mean the following branch structure?
orgin_master (the most original base before my first commit)

origin_master => libz_blitz: html_root_url_attribute_to_crate_root
origin_master => libz_blitz: use_question_mark_instead_of_unwrap_in_examples
origin_master => libz_blitz: turn_references_to_other_semver_items_int_links 
@KodrAus

This comment has been minimized.

Copy link

KodrAus commented Oct 26, 2017

That's the one! And it's absolutely no problem or bother at all. We appreciate your contributions :) It'll just be easier down the track when @steveklabnik is ready for a look.

@muzikmoe

This comment has been minimized.

Copy link
Contributor Author

muzikmoe commented Oct 26, 2017

rebased.
check out #145

@muzikmoe muzikmoe closed this Oct 26, 2017

@muzikmoe muzikmoe deleted the muzikmoe:libz_blitz/Turn_references_to_other_semver_items_int_links branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.