Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response headers are not written #71

Closed
divarvel opened this issue Oct 17, 2017 · 4 comments
Closed

Response headers are not written #71

divarvel opened this issue Oct 17, 2017 · 4 comments

Comments

@divarvel
Copy link
Contributor

divarvel commented Oct 17, 2017

In this small example (https://gist.github.com/divarvel/4c59b15d6921f79884b7638905faa4e9) we can see that headers are not written in the answer (the Location header is missing).

Indeed, write_response does not seem to include them
https://github.com/steveklabnik/simple-server/blob/master/src/lib.rs#L189

@divarvel
Copy link
Contributor Author

divarvel commented Oct 17, 2017

FWIW divarvel@d5e1be4

It needs more testing, but if that's ok with you I'll open a PR

@ashleygwilliams
Copy link
Collaborator

hey @divarvel ! thanks for filing, we may have some comments on the PR but it will be easiest to make them there, so please open one and we can chat! appreciate your work on this ✨

@divarvel
Copy link
Contributor Author

Here it is #75

@ashleygwilliams
Copy link
Collaborator

closed with #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants