1.8.0 introduced a regression that removed support for the definition's sharedscripts parameter. This commit adds a test around that parameter and restores support.
We now use the constants in the CookbookLogrotate module to validate the global configuration options and the logrotate_app options. This ensures that the options available to each stay in sync. The logrotate_app template is now more dynamically driven, ensuring that the template does not need to be updated every time an option is added.
The long_description is returned by the server to chef-client. This is wasteful and unhelpful.
Issue #60 reported a problem with the matcher that appears to be related to Ruby 1.9 hash syntax. This cookbook doesn't support Ruby 1.8, but since this is the only occurance of the 1.9 hash syntax, it is a low cost change.
Fatal error throw when invalid options are passed to the definition kills the run, which seems excessive, and worse will kill the daemon entirely when chef-client is running in daemonized mode. Instead, log an error and strip any invalid options, then continue the run.