Use Object.prototype.hasOwnProperty; not on object #32
Conversation
As of Node 6, querystring.parse() returns an object with no prototype, which means that it doesn't have its own hasOwnProperty() https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6#querystring
stevenvachon
merged commit c303588
into
stevenvachon:master
1 check passed
1 check passed
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As of Node 6, querystring.parse() returns an object with no prototype,
which means that it doesn't have its own hasOwnProperty()
https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6#querystring
Fixes #31. Note: requires the fixes in stevenvachon/urlobj#3 to pass all tests on Node 6.