Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Object.prototype.hasOwnProperty; not on object #32

Merged
merged 1 commit into from May 22, 2016
Merged

Use Object.prototype.hasOwnProperty; not on object #32

merged 1 commit into from May 22, 2016

Conversation

@scottnonnenberg
Copy link
Contributor

@scottnonnenberg scottnonnenberg commented May 20, 2016

As of Node 6, querystring.parse() returns an object with no prototype,
which means that it doesn't have its own hasOwnProperty()

https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6#querystring

Fixes #31. Note: requires the fixes in stevenvachon/urlobj#3 to pass all tests on Node 6.

As of Node 6, querystring.parse() returns an object with no prototype,
which means that it doesn't have its own hasOwnProperty()

https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6#querystring
@stevenvachon stevenvachon merged commit c303588 into stevenvachon:master May 22, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stevenvachon
Copy link
Owner

@stevenvachon stevenvachon commented May 22, 2016

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants