/urlobj

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Object.prototype.hasOwnProperty; not on object #3

Merged
merged 1 commit into from May 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@scottnonnenberg @stevenvachon
@scottnonnenberg
Contributor

scottnonnenberg commented May 20, 2016

As of Node 6, querystring.parse() returns an object with no prototype,
which means that it doesn't have its own hasOwnProperty()

https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6#querystring
@scottnonnenberg
Use Object.prototype.hasOwnProperty; not on object 
As of Node 6, querystring.parse() returns an object with no prototype,
which means that it doesn't have its own hasOwnProperty()

https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6#querystring
Loading status checks…
5396f9c

@scottnonnenberg scottnonnenberg referenced this pull request May 20, 2016

Merged

Use Object.prototype.hasOwnProperty; not on object #32

@stevenvachon stevenvachon merged commit cf91b1b into stevenvachon:master May 22, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stevenvachon

This comment has been minimized.

Sign in to view
Owner

stevenvachon commented May 22, 2016

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment