From 0d1275592a43a8aa7bf7c52354ca012f95b513fd Mon Sep 17 00:00:00 2001 From: Steve Polito Date: Sat, 5 Feb 2022 10:19:56 -0500 Subject: [PATCH] Use correct input type when collecting email addresses MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When filling out a form that collects an email address, I want my email to be validated in the browser so that I don’t find out it was incorrectly formatted when submitting the form. Issues ------ - Closes #73 --- README.md | 6 +++--- app/views/sessions/new.html.erb | 2 +- app/views/users/edit.html.erb | 2 +- app/views/users/new.html.erb | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 1e9efb6..bec3b1b 100644 --- a/README.md +++ b/README.md @@ -216,7 +216,7 @@ end <%= render partial: "shared/form_errors", locals: { object: form.object } %>
<%= form.label :email %> - <%= form.text_field :email, required: true %> + <%= form.email_field :email, required: true %>
<%= form.label :password %> @@ -557,7 +557,7 @@ end <%= form_with url: login_path, scope: :user do |form| %>
<%= form.label :email %> - <%= form.text_field :email, required: true %> + <%= form.email_field :email, required: true %>
<%= form.label :password %> @@ -992,7 +992,7 @@ end <%= render partial: "shared/form_errors", locals: { object: form.object } %>
<%= form.label :email, "Current Email" %> - <%= form.text_field :email, disabled: true %> + <%= form.email_field :email, disabled: true %>
<%= form.label :unconfirmed_email, "New Email" %> diff --git a/app/views/sessions/new.html.erb b/app/views/sessions/new.html.erb index 627acd4..2cdc067 100644 --- a/app/views/sessions/new.html.erb +++ b/app/views/sessions/new.html.erb @@ -1,7 +1,7 @@ <%= form_with url: login_path, scope: :user do |form| %>
<%= form.label :email %> - <%= form.text_field :email, required: true %> + <%= form.email_field :email, required: true %>
<%= form.label :password %> diff --git a/app/views/users/edit.html.erb b/app/views/users/edit.html.erb index 6af136e..e392417 100644 --- a/app/views/users/edit.html.erb +++ b/app/views/users/edit.html.erb @@ -2,7 +2,7 @@ <%= render partial: "shared/form_errors", locals: { object: form.object } %>
<%= form.label :email, "Current Email" %> - <%= form.text_field :email, disabled: true %> + <%= form.email_field :email, disabled: true %>
<%= form.label :unconfirmed_email, "New Email" %> diff --git a/app/views/users/new.html.erb b/app/views/users/new.html.erb index f8f2011..9598c4d 100644 --- a/app/views/users/new.html.erb +++ b/app/views/users/new.html.erb @@ -2,7 +2,7 @@ <%= render partial: "shared/form_errors", locals: { object: form.object } %>
<%= form.label :email %> - <%= form.text_field :email, required: true %> + <%= form.email_field :email, required: true %>
<%= form.label :password %>