Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Auth passing for request should not be in the URI #33

Open
wetnun opened this Issue Oct 2, 2013 · 0 comments

Comments

Projects
None yet
1 participant

wetnun commented Oct 2, 2013

By putting the user/pass into the URI you limit people to uncomplicated passwords. For example if my password was 'iL@vePa#s' it turns into 'https://user:iL@vePa%23s@host:443' which is obviously broken. request allows you to pass in the authentication information.

One possible solution for this is to create a function to generate the options and you just pass in overrides. That way you can avoid fixing all of the hard coded hashes you currently have in place in the future when you want to make changes.

Since we use complicated passwords I'm probably going to have to work on this anyways. So if I get it working I'll do a pull request.

shaunburdick pushed a commit to shaunburdick/node-jira that referenced this issue Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment