Adding in makeOptions to allow easy building of request options and defa... #34

Open
wants to merge 2 commits into
from

Projects

None yet

2 participants

@wetnun

Adding in makeOptions to allow easy building of request options and defaulting of values. Also passes in auth correctly so you can have complex passwords.

This is working with my testing so far with complex passwords that include things like '@'.

wetnun added some commits Oct 3, 2013
@wetnun wetnun Adding in makeOptions to allow easy building of request options and d…
…efaulting of values. Also passes in auth correctly so you can have complex passwords.
5ae0d61
@wetnun wetnun Left in some debug code, removing 2b68160
@lucasvo-taulia

Thank you for your pull request! I have just reviewed the pull request and found two things that I believe are lacking:

1) Documentation: could you add some information about how to use this feature to the README?
2) Tests: we're using jasmine tests. It's probaby a good idea to add some tests covering this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment