Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Get-MappedDrive function & adhere to best practices #34

Merged
merged 1 commit into from Oct 2, 2018

Conversation

@vexx32
Copy link
Contributor

commented Oct 2, 2018

Rename file & function according to best practices
Leave old name as alias
Add better error handling
Add additional drivename parameter for early filtering of results
Tidy and expand parameter definitions
tidy and expand function definition and logic
Output values over pipeline rather than at the end with return
Don't supply error data to output stream

Rename file & function according to best practices
Leave old name as alias
Add better error handling
Add additional drivename parameter for early filtering of results
Tidy and expand parameter definitions
tidy and expand function definition and logic
Output values over pipeline rather than at the end with return
Don't supply error data to output stream
@steviecoaster

This comment has been minimized.

Copy link
Owner

commented Oct 2, 2018

This looks great!

@steviecoaster steviecoaster merged commit 81a4c9d into steviecoaster:Dev Oct 2, 2018

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.