Skip to content
Commits on Jul 23, 2012
  1. @fabpot
  2. @fabpot

    updated VERSION for 2.1.0-BETA4

    fabpot committed
  3. @fabpot

    merged branch Tobion/patch-4 (PR #5022)

    fabpot committed
    Commits
    -------
    
    22dfa7d remove relict in upgrade
    
    Discussion
    ----------
    
    remove relict in upgrade
  4. @Tobion

    remove relict in upgrade

    Tobion committed
  5. @fabpot

    merged 2.0

    fabpot committed
  6. @fabpot

    merged branch parhs/2.0 (PR #5005)

    fabpot committed
    Commits
    -------
    
    5bfc25e Fixed buildViewBottomUp docs
    
    Discussion
    ----------
    
    Fixed buildViewBottomUp docs
    
    Fixed documentation
  7. @fabpot
  8. @fabpot

    merged branch lyrixx/patch-security (PR #5020)

    fabpot committed
    Commits
    -------
    
    e1f1d3a Added missing property
    
    Discussion
    ----------
    
    [Security] Added missing property
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
  9. @lyrixx

    Added missing property

    lyrixx committed
  10. @fabpot

    merged branch drak/nativefile_savepath (PR #5016)

    fabpot committed
    Commits
    -------
    
    ff273af [HttpFoundation][Sessions] Micro-optimization
    9bf3cb4 [HttpFoundation][Sessions] Add support for extended save_path for native files save handler
    
    Discussion
    ----------
    
    [Sessions] Add support for extended save_path for native files save handler
    
    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4908
    Todo: -
    License of the code: MIT
    Documentation PR: -
  11. @fabpot

    merged branch bamarni/patch-2 (PR #5018)

    fabpot committed
    Commits
    -------
    
    91415b1 removed unneeded class to compile
    
    Discussion
    ----------
    
    removed unneeded class to compile
    
    As the redirectable matcher a few lines below is a child class.
    
    I'm not sure if it's the other one that should be removed instead? As it's not always required, when using the apache matcher for example.
  12. [HttpFoundation][Sessions] Micro-optimization

    Drak committed
  13. @bamarni
  14. [HttpFoundation][Sessions] Add support for extended save_path for nat…

    Drak committed
    …ive files save handler
Commits on Jul 22, 2012
  1. @fabpot

    merged branch bschussek/propertypath (PR #5011)

    fabpot committed
    Commits
    -------
    
    dd2aa54 [Form] Disabled manual singulars in PropertyPath until the syntax is finalized
    
    Discussion
    ----------
    
    [Form] Disabled manual singulars in PropertyPath until the syntax is finalized
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
  2. @fabpot
  3. @webmozart
  4. @fabpot

    merged branch bschussek/renderer (PR #5006)

    fabpot committed
    Commits
    -------
    
    dc3a680 [Form] Improved FormRenderer API to reduce the size of the function call stack during rendering
    
    Discussion
    ----------
    
    [Form] Improved FormRenderer API to decrease the function call stack
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: **yes**
    Symfony2 tests pass: yes
    Fixes the following tickets: #4962, #4973
    Todo: -
    
    This PR reduces the function call stack size when rendering by directly calling the methods `renderBlock` and `searchAndRenderBlock` (formerly `renderSection`) and removing the delegating methods `render(Widget|Label|Row|...)`.
    
    It breaks BC in that PHP templates now need to pass the FormView instance to `block` (formerly `renderBlock`). This is necessary, otherwise that function may behave buggy in special circumstances.
    
    Otherwise this PR cleans up API method and parameter names to improve clarity.
  5. @fabpot

    merged branch bschussek/issue4960 (PR #5010)

    fabpot committed
    Commits
    -------
    
    eccc5bd [Form] Restored BC in AbstractType::getDefaultOptions() and getAllowedOptionValues()
    
    Discussion
    ----------
    
    [Form] Restored BC in AbstractType::getDefaultOptions() and getAllowedOptionValues()
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4960
    Todo: -
  6. @webmozart
  7. @webmozart

    [Form] Improved FormRenderer API to reduce the size of the function c…

    webmozart committed
    …all stack during rendering
Commits on Jul 21, 2012
  1. @fabpot
  2. @fabpot

    merged branch bschussek/options_performance (PR #5004)

    fabpot committed
    Commits
    -------
    
    24b764e [Form] Fixed issues mentioned in the PR
    9216816 [Form] Turned Twig filters into tests
    310f985 [Form] Added a layer of 2.0 BC methods to FormView and updated UPGRADE and CHANGELOG
    5984b18 [Form] Precalculated the closure for deciding whether a choice is selected (PHP +30ms, Twig +30ms)
    5dc3c39 [Form] Moved the access to templating helpers out of the choice loop for performance reasons (PHP +100ms)
    0ef9acb [Form] Moved the method isChoiceSelected() to the ChoiceView class (PHP +150ms)
    8b72766 [Form] Tweaked the generation of option tags for performance (PHP +200ms, Twig +50ms)
    400c95b [Form] Replace methods in ChoiceView by public properties (PHP +100ms, Twig +400ms)
    d072f35 [Form] The properties of FormView are now accessed directly in order to increase performance (PHP +200ms, Twig +150ms)
    
    Discussion
    ----------
    
    [Form] Made FormView and ChoiceView properties public for performance reasons
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: **yes**
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    
    This PR changes the access to properties of `FormView` and `ChoiceView` objects from getters to direct property accesses. On [my example form](http://advancedform.gpserver.dk/app_dev.php/taxclasses/1) this improves rendering performance for **300ms** with PHP templates and **550ms** with Twig on my local machine.
    
    Unfortunately, this breaks BC both with 2.0 and with the current master in Form Types and PHP templates. Twig templates are not affected by this change.
    
    2.0:
    ```
    $formView->set('my_var', 'foobar');
    $formView->get('my_var');
    $formView->getChild('childName');
    $formView['childName'];
    ```
    
    master:
    ```
    $formView->setVar('my_var', 'foobar');
    $formView->getVar('my_var');
    $formView->get('childName');
    $formView['childName'];
    ```
    
    this PR:
    ```
    $formView->vars['my_var'] = 'foobar';
    $formView->vars['my_var'];
    $formView->children['childName'];
    $formView['childName'];
    ```
    
    Should we add methods to keep BC with 2.0?
    
    The second part of this PR contains improvements to the rendering of choice fields. These gain another **~500ms** for PHP templates and **80ms** for Twig. These improvements are BC, unless you overwrote the block "choice_widget_options" in your form themes which then needs to be adapted.
    
    **Update:**
    
    The PR now includes a BC layer for 2.0.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-07-21T11:37:41Z
    
    @bschussek couldn't we keep the getters and setters for BC even if the rendering accesses the public properties directly ?
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-07-21T11:52:33Z
    
    @stof A BC layer for 2.0 is now included. People who upgraded to master already unfortunately need to adapt their code.
    
    ---------------------------------------------------------------------------
    
    by sstok at 2012-07-21T12:40:57Z
    
    :+1:
  3. @webmozart
  4. @webmozart
  5. @webmozart
  6. @fabpot

    merged branch KaipiYann/Fix-DocBlock-attemptAuthentication (PR #4996)

    fabpot committed
    Commits
    -------
    
    134cc84 [Security] Fix DocBlock of attemptAuthentication
    
    Discussion
    ----------
    
    [Security] Fix DocBlock of attemptAuthentication
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets:
    Todo: -
    License of the code: MIT
    Documentation PR: -
  7. @fabpot

    merged branch Slamdunk/hotfix/late-static-create (PR #4991)

    fabpot committed
    Commits
    -------
    
    9dc2011 Late static factory method
    
    Discussion
    ----------
    
    Late static factory method
    
    When using `Symfony\CS\Finder\DefaultFinder::create()`, we lose all `Symfony\CS\Finder\DefaultFinder::__construct()` properties because main `Finder` does not use late static binding.
    
    This commit resolves the issue.
  8. @fabpot

    merged branch bschussek/setdata_performance (PR #5003)

    fabpot committed
    Commits
    -------
    
    d4f4038 [Form] Reduced the number of setData() calls by deferring a Form's initialization (+40ms)
    
    Discussion
    ----------
    
    [Form] Reduced the number of setData() calls
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    
    This PR decreases the number of expensive `setData()` calls on `Form` instances by deferring the form's initialization with default data to the first call to a `get*Data()` method. If `setData()` is called manually before invoking `get*Data()`, the initialization with the default data will not take place.
    
    Before:
    
    ```
    $form = new Form($config); // implicit setData($config->getData());
    $form->setData($object); // setData() is now called twice
    ```
    
    After:
    
    ```
    $form = new Form($config); // no implicit setData()
    $form->getData(); // implicit setData($config->getData())
    
    // or
    
    $form = new Form($config);
    $form->setData($object);
    $form->getData(); // setData() was called only once
    ```
  9. @fabpot

    merged branch ddebree/patch-1 (PR #5001)

    fabpot committed
    Commits
    -------
    
    37bbd0f Moved symfony/config from the "recommend" dependency to the "suggest" dependency. Cannot find "recommend" in composer documentation
    
    Discussion
    ----------
    
    Moved symfony/config from the "recommend" dependency to the "suggest" dependancy
    
    Moved symfony/config from the "recommend" dependency to the "suggest" dependency. Cannot find "recommend" in composer documentation
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-07-21T10:52:19Z
    
    Recommend used to exist but was removed.
    
    :+1:
  10. @fabpot

    merged branch bschussek/filtertonormalizer (PR #5002)

    fabpot committed
    Commits
    -------
    
    3075fa6 [OptionsResolver] Renamed filters to normalizers
    
    Discussion
    ----------
    
    [OptionsResolver] Renamed filters to normalizers
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    
    This PR fixes the naming to be in line with the Serializer component.
  11. @webmozart
  12. @webmozart
  13. @webmozart

    [Form] Precalculated the closure for deciding whether a choice is sel…

    webmozart committed
    …ected (PHP +30ms, Twig +30ms)
  14. @webmozart

    [Form] Moved the access to templating helpers out of the choice loop …

    webmozart committed
    …for performance reasons (PHP +100ms)
Something went wrong with that request. Please try again.