Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide show group VMs tick box when it would have no effect #64

Closed
GRyall opened this issue Jan 25, 2016 · 2 comments
Closed

hide show group VMs tick box when it would have no effect #64

GRyall opened this issue Jan 25, 2016 · 2 comments
Assignees
Milestone

Comments

@GRyall
Copy link

GRyall commented Jan 25, 2016

Not all groups will want to see each others VMs, so having the tick box will just be a source of confusion for users. It would be good if it wasn't visible in this case. The case can be identified by the list of the users VMs being the same length as the one when they see all the ones visible to them. Alternatively, the longer of the lists could be examined for VMs not owned by the user.

@GooBall
Copy link
Contributor

GooBall commented Jan 26, 2016

To be clear... To avoid confusion, users should only be able to see the tick-box option if they are part of a group that has VMs besides the ones that the individual has created themselves.

I do have a question though. Might a user ever be part of more than 1 group? If so, would it make sense to use a dropdown (instead of a tick-box) with the names of all the groups they are a member of?

This could mean that, if you were not part of a group, you wouldn't be able to select anything other then your own view - thereby removing the need to hide the dropdown/tick-box.

@GooBall
Copy link
Contributor

GooBall commented Feb 24, 2016

Implemented in #75 and #76

@GooBall GooBall closed this as completed Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants