Another fix for stray objects in Rails 3 #156

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@melindaweathers

Greetings. I saw the previous commit that fixed a stray object issue, but I was still encountering stray objects in my Rails 3.2 associations when doing filter_resource_access with a :nested_in. This change alleviates the problem.

Before my change, all tests were passing for me except one, and after my change, that is still the case. I'm not sure where in the tests to add something to test this fix, however. Suggestions welcome.

Fixed a case where stray objects were getting added to a collection i…
…n the case of a nested filter_resource_access.
@stffn

This comment has been minimized.

Show comment Hide comment
@stffn

stffn Jan 20, 2013

Owner

Thanks for the patch and sorry that it took me so long to review it. Unfortunately, I can only merge pull requests if they include a failing test that is solved by the change. Can you provide it?

Owner

stffn commented Jan 20, 2013

Thanks for the patch and sorry that it took me so long to review it. Unfortunately, I can only merge pull requests if they include a failing test that is solved by the change. Can you provide it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment