Sync Fork from Upstream Repo #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConceptSpecializationExprs (CSEs) were being created with nullptr TemplateArgsAsWritten during TemplateTemplateParmDecl canonicalization, and we were relying on them during profiling which caused sporadic crashes in test/CXX/.../temp.arg.template/p3-2a.cpp introduced in D44352. Change profiling of CSEs to instead rely on the actual converted template arguments and concept named.
If there are DBG_VALUEs between phi and label (after phi and before label),
DBG_VALUE will block PHI lowering after the LABEL. Moving all DBG_VALUEs
after Labels in the function ScheduleDAGSDNodes::EmitSchedule to avoid
impacting PHI lowering.
before:
PHI
DBG_VALUE
LABEL
after: (move DBG_VALUE after label)
PHI
LABEL
DBG_VALUE
then: (phi lowering after label)
LABEL
COPY
DBG_VALUE
Fixes the issue: https://bugs.llvm.org/show_bug.cgi?id=43859
Differential Revision: https://reviews.llvm.org/D70597
This feature landed before the 10.x branch, so it will be covered in the clang 10 release notes instead.
expect_expr is the stricter and safer way of testing these expressions.
Use castAs<> instead of getAs<> since the pointer is dereferenced immediately in all cases and castAs will perform the null assertion for us.
Summary: Makes use of insertion order to stabilize output for multiple decls. Fixes https://bugs.llvm.org/show_bug.cgi?id=44564 Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, mgrang, arphaman, usaxena95, cfe-commits, aemerson Tags: #clang Differential Revision: https://reviews.llvm.org/D72826
Moved the section name check ahead of any filename matching or exclusion. Firstly, this reduces the need to retrieve the filename and secondly, reduces the amount of potentially expensive filename pattern matching if such rules are present in the linker script. The impact of this change is particularly significant when linking objects built with -ffunction-sections and -fstack-size-section, using a linker script that includes non-trivial filename patterns. In a number of such cases, the link time is halved. Differential Revision: https://reviews.llvm.org/D72775
Testing compiler-rt, a new assertion failure occurs when building the GwpAsanTestObjects object. I'm uploading a reproducer to D70597. This reverts commit 75188b0.
r354605 moved LLD to the unified revision handling introduced in rL353268 / r352729 and removed uses of LLD_REPOSITORY_STRING and LLD_REVISION_STRING. After this change, we no longer compute the (now-unused) values of these two variables. Since this removes the only use of llvm/utils/GetRepositoryPath, remove that too (it's redundant with the system added in r354605). While here, also remove LLD_VERSION_MAJOR and LLD_VERSION_MINOR. Their uses were removed in r285163. Also remove LLD_VERSION from Version.inc which as far as I can tell has been unused since the file was added in r219277. No behavior change. Differential Revision: https://reviews.llvm.org/D72803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.