Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Droid] Clipping using individual corner radii #2

Closed
sthewissen opened this issue Feb 14, 2019 · 4 comments
Closed

[Droid] Clipping using individual corner radii #2

sthewissen opened this issue Feb 14, 2019 · 4 comments
Labels
help wanted Extra attention is needed up for grabs Available for someone who feels like implementing it

Comments

@sthewissen
Copy link
Owner

Currently, clipping occurs using only one corner radius for all the corners. It would be nice if clipping can be done using the individual corner radii for each corner. This does work on iOS already, however it doesn't work on Android. The current ViewOutlineProvider doesn't seem to support it.

@sthewissen sthewissen added help wanted Extra attention is needed up for grabs Available for someone who feels like implementing it labels Feb 14, 2019
@modplug
Copy link

modplug commented Feb 21, 2019

@sthewissen
Copy link
Owner Author

sthewissen commented Feb 21, 2019

We do something very similar when drawing the actual rounded corners on the background and the borders as what FFImageLoading is doing when drawing their images.

However, the difference is that FFImageLoading deals with an image, which isn't a content container and can't contain child controls. The problem we're running into is that PancakeView is a layout that can contain one or more layouts and controls which need to be clipped to the parent view (in this case the PancakeView). Drawing the corners works just fine, however if content exceeds these corners it will simply overlap them.

Hope that makes sense :)

@modplug
Copy link

modplug commented Feb 21, 2019

It sure does. Thanks for the explanation 👍

@sthewissen
Copy link
Owner Author

This is fixed in the latest 1.24-beta release. Please feel free to experiment if you feel like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed up for grabs Available for someone who feels like implementing it
Projects
None yet
Development

No branches or pull requests

2 participants