Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check files inside node_modules #258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

neslinesli93
Copy link

@neslinesli93 neslinesli93 commented Mar 22, 2021

Hi, thank you for your work on elm-analyse :)

This PR aims to solve #236, which afaik is an intended behaviour which solves #22, an old issue you opened up yourself. This is a proposal to rollback that behaviour, for two reasons:

  • the NoUnusedDependencies check cannot be configured nor disabled in any way at this moment
  • the fact to ignore node_modules can be easily configured from elm-analyse.json, and I think nowadays is more common to have a couple folder with elm sources and that can be manually added to elm-analyse.json rather than using . as the scope for all elm files

Finally, I've also added a Dockerfile so that the project can be built easily, in spite of all the versions of node/npm/typescript one may have on their own system.

EDIT: the windows build fails because it fails to install elm-platform. Any clue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant