Support GlobalId objects#94
Merged
julianrubisch merged 2 commits intostimulusreflex:masterfrom Apr 30, 2021
Merged
Conversation
Contributor
Author
|
@julianrubisch I broke this up into two commits. The first aad48f2 refactors the tests slightly because we were re-implementing some of the functionality (my fault from a previous refactor). The tests now more directly tests that the element has the correct parameters. The second commit provides the support for GlobalId-ed objects. |
Contributor
|
LGTM but we appear to have conflicts |
rickychilcott
force-pushed
the
support-global-id-objects
branch
from
becb911 to
e0f995c
Compare
Contributor
Author
|
Corrected! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Description
Allows any local to be a GlobalId-able object
Fixes #91
Checklist