Use rails convention to underscore collection class names#95
Merged
julianrubisch merged 1 commit intoApr 30, 2021
Merged
Conversation
This would mean a class such as `ActionItem` when evaluated in a partial would show up as `actionitem` instead of the expected `action_item`. Users of the library could override this with the `as:` option. Added extensive tests to ensure broadcast and `futurize` generator properly generate Note this is a breaking change for users, but is correct in following rails conventions.
Contributor
Author
|
Sorry to bombard you @julianrubisch. Real-world use of this library is highlighting a few items for me. |
Contributor
|
Good catch, keep it coming! Don't see an issue since we're targeting 1.0 anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
Description
This would mean an object such as
ActionItemwhen evaluated in a partial would show up asactionitemby default, instead of the expectedaction_item. Users of the library could override this with theas:option, such asas: :action_itemin this case.Prior to the change, this code would be need:
Whereas, we would expect the following to work
Why should this be added
This follows Rails conventions and the principle of least surprise. However, this is a breaking change for users of this library, but is correct in following Rails conventions.
Checklist