Permalink
Switch branches/tags
Nothing to show
Commits on Dec 21, 2009
  1. Syntactically correct example in FB.Data.query.

    Luke Shepard committed Dec 21, 2009
    Reviewed By: wzhu
  2. Tweak documentation for XFBML and data layer

    Luke Shepard committed Dec 21, 2009
    Summary:
    I cleaned up and clarified the docs for data layer and XFBML.
    
    See here:
    
    http://developers.lshepard.devrs006.facebook.com/docs/?u=facebook.joey.FB
    
    Reviewed By: wzhu
    
    Test Plan:
    Browsed all affected nodes here:
    
    http://developers.lshepard.devrs006.facebook.com/docs/?u=facebook.joey.FB
    
    Ran unit tests. Tried the examples in the console to verify that they worked.
    
    Revert: OK
    
    DiffCamp Revision: 80908
Commits on Dec 19, 2009
  1. Changelog for alpha release of data layer and XFBML.

    Luke Shepard committed Dec 19, 2009
  2. Remove references to FB.App and fix XFBML unit tests

    Luke Shepard committed Dec 19, 2009
    Reviewed By: wzhu
    
    Test Plan: Ran the non-interactive unit tests in FF3 and Safari.
Commits on Dec 18, 2009
  1. Change pkg.sh to explicitly use bash

    Luke Shepard committed Dec 18, 2009
    Reviewed By: ccheever
    
    Issue: http://github.com/facebook/connect-js/issues/#issue/21
    
    Test Plan: ./pkg.sh > m.js
  2. Update comments for FB.Data and FB.XFBML

    Wei Zhu committed Dec 18, 2009
    Summary:
    Update comments for FB.Data and FB.XFBML
    
    Reviewed By: ahimel
    
    Test Plan:
    just comments
    
    Revert: OK
    
    DiffCamp Revision: 80654
    
    Other Notes:
    
    EImportant:
    
    - begin *PUBLIC* platform impact section -
    Bugzilla: #
    - end platform impact -
  3. Modify @static and a few @private in joey

    Luke Shepard committed Dec 18, 2009
    Summary:
    To accomodate the new format
    
    Reviewed By: wzhu
    
    Test Plan:
    Same as r208152
    
    Revert: OK
    
    DiffCamp Revision: 80631
Commits on Dec 17, 2009
  1. XFBML unit tests about halfway

    Luke Shepard committed Dec 17, 2009
    Summary:
    After much experimentation I settled on a regex approach for the XFBML unit tests.
    
    This diff gets us near 100% coverage for login-button and profile-pic, and most coverage for fb:name (except for all the pronoun combos), and not much for fb:share.
    
    Also ... it doesn't work in all browsers. In FF3 they pass but in Safari and IE7, not always. In Safari they don't even render.
    
    Reviewed By: wzhu
    
    Test Plan:
    Ran the unit tests in FF3, Safari, and IE7.
    
    For some reason the regexes in IE7 don't pass all the time, so I get some failures, and in Safari the XFBML tags don't render.
    
    http://www.lshepard-connect-js.devrs006.facebook.com/fbconnect/tests/index.html?fb:
    
    Revert: OK
    
    DiffCamp Revision: 80333
Commits on Dec 10, 2009
  1. Add unit tests for XFBML parser

    Luke Shepard committed Dec 10, 2009
    Summary:
    Wrote unit tests for type system and XFBML framework in Joey. This diff does NOT include any tests for the actual tags. We are at 100% coverage for element.js, type.js, waitable.js, and close enough for xfbml.js - except for some statements which are error conditions and specific browser tests.
    
    Also, in doing this I changed a little bit of the way we load tags. Rather than having the component be specified explicitly (which I think is redundant), just change the component name to always be a function of the tag name. That way it can be dynamically determined.
    
    I also want as a design goal that the system should be able to work without dynamic loading - it's exclusively an optional feature, especially since it involves a server-side component. So now, instead of checking if the component has been loaded (which means something has to call FB.Component.scriptLoaded), instead we just check to see if the class has been defined - and if so, just go with that.
    
    Reviewed By: wzhu
    
    Test Plan:
    Ran all the non-UI unit tests in FF3, Safari, and IE8. Saw code coverage and they all passed. (Except for some of the data ones, but that's a server bug that Ray is working on)
    
    Revert: OK
    
    DiffCamp Revision: 78925
Commits on Dec 8, 2009
  1. Refactor loader.js, use.js in Joey libraries

    Luke Shepard committed Dec 8, 2009
    Summary:
    This diff gets rid of the multi-level nested directory structure in Joey library. I don't really like common/core and common/extended and core, etc.
    
    This is not quite ideal yet, but I think it's a good first step. Basically, I made the following changes:
    
    - loader.js => component.js
    - use.js => loader.js
    
    It's a lot clearer to me to have two separate modules - Loader and Component - instead of sub-modules within the same namespace.
    
    Since component.js is needed in the prelude for every script, I moved it into core, while leaving loader.js in its own directory.
    
    I also moved everything in common/extended into just plain common/.
    
    This diff is big and scary; check here for the actual changes I made to the respective files:
    
    http://www.intern.facebook.com/intern/diffcamp/?diffID=222616
    
    Reviewed By: wzhu
    
    Test Plan:
    Ran the new loader.js unit test. In fact, the test only passed if I changed the implementation of _check; (why was that .create() statement in there?)
    
    Revert: OK
    
    DiffCamp Revision: 78077
Commits on Dec 5, 2009
  1. Data and XFBML for Joey

    Wei Zhu committed Dec 5, 2009
    Summary:
    Adding data and XFBML layer to Joey.
    
    Thanks Luke for writting unit tests for the data layer and writting error handling code.
    Reviewed By: lshepard
    
    Other Commenters: ahimel
    
    Test Plan:
    
    Luke wrote unittest for the data layer
    
    Here are some of my simple test pages
    http://www.wzhu-git.devrs002.facebook.com/fbconnect/tests/data_test.html
    
    http://www.wzhu-git.devrs002.facebook.com/fbconnect/tests/xfbml_test.html
    
    Revert: OK
    
    DiffCamp Revision: 76756
Commits on Dec 4, 2009
  1. Change/add FB.copy, FB.provide, FB.log, FB.$, FB.forEach

    Wei Zhu committed Dec 4, 2009
    Summary:
    This is part of change for Data and XFBML. I am doing the prelude.js change first to make review easier.
    
    Reviewed By: lshepard
    
    Test Plan:
    Create new unit tests and passed them.
    
    Revert: OK
    
    DiffCamp Revision: 77837
    
    Other Notes:
    
    EImportant:
    
    - begin *PUBLIC* platform impact section -
    Bugzilla: #
    - end platform impact -
Commits on Nov 25, 2009
  1. Change FB.login to take options instead of just "perms"

    Luke Shepard committed Nov 25, 2009
    Summary:
    Changed FB.login to take a bag of options instead of just a single second parameter. This will let us expand in the future if we want to - and will better match the changes I'm planning to make next to FB.ui and FB.logout.
    
    Also changed the parameter name for FB.init to match.
    
    Reviewed By: naitik
    
    Test Plan:
    Ran the full suite of unit tests, and clicked around the console.
    
    Note that I had to change my API key in js/initialize.js to make this work (which I won't commit). I will probably need to make changes similar to my other diff in order to make this work smoothly.
    
    Revert: OK
    
    DiffCamp Revision: 76611
Commits on Nov 20, 2009
  1. auth.revokeauthorization needs case insensitive check

    daaku committed Nov 19, 2009
    Reviewed By: ahimel
    
    CC:platform-diffs@lists.facebook.com
    
    Test Plan: Added tests to make sure it doesnt happen again.
    
    DiffCamp Revision: 75451
  2. empty value bug in FB.QS.decode

    daaku committed Nov 19, 2009
    Summary:
    Decoding the empty string '' was returning an object with key '' (the empty
    string) and value of undefined. This fixes it.
    
    Reviewed By: ahimel
    
    CC: platform-diffs@lists.facebook.com
    
    Test Plan: Added unit test to make sure it doesnt happen again.
    
    DiffCamp Revision: 75452
  3. Updating cookie format to be quoted to follow the RFC

    daaku committed Nov 19, 2009
    Summary:
    We were including the '=' sign in our cookie. This is not valid according to
    the RFC unless the value is quoted. This breaking change adds those quotes to
    our cookie value. This was reported on Github with relation to Apache Tomcat
    which follows the RFC:
    http://github.com/facebook/connect-js/issues/#issue/2/comment/77244
    
    This is the first breaking change since the initial alpha release. I've created
    a changelog.md file and linked it from the readme.
    
    Reviewed By: lshepard
    
    CC:platform-diffs@lists.facebook.com
    
    Test Plan: Ran tests.
    
    DiffCamp Revision: 75467
  4. Fix typo causing invalid statusChange events

    daaku committed Nov 19, 2009
    Summary:
    It's _userStatus not _status. Was causing the statusChange event to get fired
    for pretty much all cases. This fixes it.
    
    Reviewed By: ahimel
    
    CC:platform-diffs@lists.facebookc.com
    
    Test Plan:Added a test to make sure it doesn't happen again.
    
    DiffCamp Revision: 75471
Commits on Nov 19, 2009
  1. insertIframe doc block correction

    daaku committed Nov 19, 2009
    Reviewed By: brent
    
    CC:platform-diffs@lists.facebook.com
    
    Test Plan: None.
    
    DiffCamp Revision: 75447
Commits on Nov 10, 2009
  1. Using Events framework rather than callbacks array for FB.loginStatus…

    Alex Himel committed Nov 10, 2009
    … implementation.
    
    Summary:
    
    Task ID: #
    
    Blame Rev:
    
    Reviewers:naitik,wzhu,lshepard
    
    CC:platform-diffs@lists.facebook.com
    
    Test Plan:Added unit test methdo for new FB.Event.clear and verified
    that all tests in tests/index.html continue to pass.
    
    Revert Plan:
    
    Tags:
    
    Database Impact:
    
    Memcache Impact:
    
    Other Notes:
    
    EImportant:
    
    - begin *PUBLIC* platform impact section -
    Bugzilla: #
    - end platform impact -
    
    DiffCamp Revision: 73610
Commits on Nov 5, 2009
  1. Doc formatting updates

    daaku committed Nov 5, 2009
    Summary:
    Only updating the public methods for now. The rest will follow. Also linking
    methods directly, we need to eventually make the [[js:XX]] style links be
    "localized" so they're relative to the active top root module.
    
    Tables and definition lists are not pretty, but they're better than the text
    garbage we'd otherwise show. We can clean that up after.
    
    Reviewers: lshepard
    
    CC: platform-diffs@lists.facebook.com
    
    Test Plan: http://developers.naitik.dev575.snc1.facebook.com/docs/?u=facebook.jslib-alpha.FB
    
    DiffCamp Revision: 72928
  2. remove @module tags from connect js

    Luke Shepard committed Nov 5, 2009
    Summary: This cleans up unnecessary tags, and change FB.EventProvider to FB.Event so that it's doced correctly.
    There's still some crap that doesn't work but it's all mostly in private methods - public stuff displays correctly.
    
    Reviewed By: naitik
    
    Test Plan: viewed docs in sandbox: http://developers.lshepard_connect_js.devrs006.facebook.com/docs/?u=facebook.jslib-alpha.FB
  3. Typo in readme

    daaku committed Nov 5, 2009
    Summary:
    double is.
  4. Final URL is not /assets.php/, its /connect/

    daaku committed Nov 5, 2009
    Summary:
    Replacing assets.php with connect.
    
    Reviewed By: brent
    
    CC: platform-diffs@lists.facebook.com
    
    Test Plan: None.
    
    DiffCamp Revision: 72861
Commits on Nov 4, 2009
  1. Typo in readme

    daaku committed Nov 4, 2009
    Summary:
    Minor typo in readme.
    
    Reviewed By: ahimel
    
    CC: platform-diffs@lists.facebook.com
    
    Test Plan: None.
  2. Updates to readme

    daaku committed Nov 4, 2009
    Summary:
    Fixing formatting issues with the readme.
    
    Reviewers: davidrecordon, lshepard
    
    CC: platform-diffs@lists.facebook.com
    
    Test Plan: None.
  3. Adding readme.md

    daaku committed Nov 4, 2009
    Summary:
    Adding a readme file with information about the release.
    
    Reviewed By: davidrecordon
    
    Other Commenters: cat
    
    CC: platform-diffs@lists.facebook.com, cat
    
    Test Plan: None.
    
    DiffCamp Revision: 72705
  4. Upgrade request params to specify session_version=2 to get the new si…

    daaku committed Nov 3, 2009
    …gnature
    
    Summary:
    
    Updates the URLs to login_status.php and login.php to specify the using the new
    version of session signature.
    
    Reviewed By: brent
    
    CC: platform-diffs@lists.facebook.com
    
    Test Plan:
    Tested as part of the PHP diff by validating the signature in the following
    flows:
    - login staus
    - login (already granted -- sign in another tab)
    - tos
    - login (email/pass)
    - login + offline access
    - tos + offline access
    - offline access
    
    DiffCamp Revision: 72351
  5. Merge branch 'some_renaming'

    daaku committed Nov 4, 2009
  6. Add other contributors to md5sum.js

    daaku committed Nov 4, 2009
    Summary:
    Adding other contributors to md5sum.js.
    
    Reviewed By: davidrecordon
    
    CC: platform-diffs@lists.facebook.com
    
    Test Plan: None.
    
    DiffCamp Revision: 72704
  7. Remove Google Analytics

    daaku committed Nov 4, 2009
    Summary:
    Removing Google Analytics code from Mu time.
    
    Reviewers: ahimel, lshepard
    
    CC: platform-diffs@lists.facebook.com
    
    Test Plan: None.
    
    DiffCamp Revision: 72592
  8. md5sum.js should be BSD licensed as it is inspired by a BSD licensed …

    daaku committed Nov 4, 2009
    …library
    
    Summary:
    Updating the License header for md5sum.js to accurately represent the BSD
    license.
    
    Reviewers: davidrecordon
    
    CC: platform-diffs@lists.facebook.com
    
    Test Plan: None.
    
    DiffCamp Revision: 72553