Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zrank/zrevrank #851

Merged
merged 5 commits into from Oct 7, 2019
Merged

feat: add zrank/zrevrank #851

merged 5 commits into from Oct 7, 2019

Conversation

@if1live
Copy link
Contributor

if1live commented Sep 1, 2019

I use zrange, zrevrange to implement zrank/zrevrank.

unit test is based on redis document.

use zrange, zrevrange
@codeclimate

This comment has been minimized.

Copy link

codeclimate bot commented Sep 1, 2019

Code Climate has analyzed commit b93b4cd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.6% (0.0% change).

View more on Code Climate.

if1live and others added 2 commits Sep 2, 2019
@stipsan
stipsan approved these changes Oct 4, 2019
if1live and others added 2 commits Oct 7, 2019
@stipsan stipsan merged commit eeb3905 into stipsan:master Oct 7, 2019
15 checks passed
15 checks passed
Lint and build
Details
Test on node 8 and ubuntu-latest
Details
Test on node 8 and windows-latest
Details
Test on node 8 and macOS-latest
Details
Test on node 10 and ubuntu-latest
Details
Test on node 10 and windows-latest
Details
Test on node 10 and macOS-latest
Details
Test on node 12 and ubuntu-latest
Details
Test on node 12 and windows-latest
Details
Test on node 12 and macOS-latest
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (80% threshold)
Details
codeclimate/total-coverage 98% (0.0% change)
Details
@stipsan

This comment has been minimized.

Copy link
Owner

stipsan commented Oct 7, 2019

Thanks for your contribution @if1live! 🎉

@stipsan

This comment has been minimized.

Copy link
Owner

stipsan commented Oct 7, 2019

🎉 This PR is included in version 4.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stipsan stipsan added the released label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.