Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. #13

Open
polynar opened this Issue Feb 14, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@polynar
Copy link
Contributor

polynar commented Feb 14, 2019

Can you make nicescroll passive?

Edit
I got three of them in my console and if i open notifications or messages dropdown i get more.
screenshot 2019-02-14 09 51 45

@nauvalazhar

This comment has been minimized.

Copy link
Member

nauvalazhar commented Feb 14, 2019

Back to basic. Do we need NiceScroll? I plan to remove or replace it with another one. Too much NiceScroll I don't think it's so good.

@polynar

This comment has been minimized.

Copy link
Contributor Author

polynar commented Feb 14, 2019

I agree with you.

@nauvalazhar

This comment has been minimized.

Copy link
Member

nauvalazhar commented Feb 14, 2019

GitLab had a good conversation about this
https://gitlab.com/gitlab-org/gitlab-ce/issues/15664

@polynar

This comment has been minimized.

Copy link
Contributor Author

polynar commented Feb 16, 2019

@nauvalazhar

This comment has been minimized.

Copy link
Member

nauvalazhar commented Feb 16, 2019

I can just delete NiceScroll, but, will using the default scrollbar look good?

@polynar

This comment has been minimized.

Copy link
Contributor Author

polynar commented Feb 16, 2019

No, I don't think so, i search a sulution for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.