Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout skins #135

Open
muhammaddicky opened this issue Dec 13, 2019 · 9 comments
Open

Add layout skins #135

muhammaddicky opened this issue Dec 13, 2019 · 9 comments
Assignees

Comments

@muhammaddicky
Copy link
Contributor

@muhammaddicky muhammaddicky commented Dec 13, 2019

I recently add style layout skins for more options for users to choose what layout skin they prefer. I also add floating button for change layout skin, so users can see all layout skins trough all page.

This is some progress i have been made.
stisla-layout-skins
stisla-layout-skins-2

If you want i can continue and create PR when this ready.

@nauvalazhar

This comment has been minimized.

Copy link
Member

@nauvalazhar nauvalazhar commented Dec 13, 2019

Wow. Can you show me the code and live preview link?

@muhammaddicky

This comment has been minimized.

Copy link
Contributor Author

@muhammaddicky muhammaddicky commented Dec 13, 2019

@nauvalazhar For now, is still on my local and working some other components, i have to check every components on every page to make sure i dont miss some components.

@muhammaddicky

This comment has been minimized.

Copy link
Contributor Author

@muhammaddicky muhammaddicky commented Dec 14, 2019

@nauvalazhar You can check my progress here for now.

@nauvalazhar

This comment has been minimized.

Copy link
Member

@nauvalazhar nauvalazhar commented Dec 14, 2019

Looks great. But, what about the button variations, alert and some other components? I mean, let's say we use green skin, it will definitely cause color conflicts with success. But, conceptually, I like what you make.

@muhammaddicky

This comment has been minimized.

Copy link
Contributor Author

@muhammaddicky muhammaddicky commented Dec 14, 2019

@nauvalazhar That is what user must decided if user want to use this style or we set up alternative color for conflict skin, so when user change skin all element that have conflict color will change to alternative color.

@nauvalazhar

This comment has been minimized.

Copy link
Member

@nauvalazhar nauvalazhar commented Dec 14, 2019

Interesting. I think we need to have several variables in the skin file, one of which is to adjust the color. And also makes it easier for developers to make their own skin color.

@muhammaddicky

This comment has been minimized.

Copy link
Contributor Author

@muhammaddicky muhammaddicky commented Dec 14, 2019

Yeah, or just one alternative color maybe enough because conflict only happen to one color right. I'm also already create mixin where user can choose what components and skin that user wanna compile. You can check my example to handle that conflict color here

@nauvalazhar

This comment has been minimized.

Copy link
Member

@nauvalazhar nauvalazhar commented Dec 15, 2019

Great. Can't wait to see it finish.

@muhammaddicky

This comment has been minimized.

Copy link
Contributor Author

@muhammaddicky muhammaddicky commented Dec 15, 2019

Yeah, you can update this issue by assign me for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.