Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About color #49

Open
jyxjjj opened this Issue Mar 26, 2019 · 11 comments

Comments

Projects
None yet
6 participants
@jyxjjj
Copy link

jyxjjj commented Mar 26, 2019

Oh.
Don't you think it is too bright?
Too white.
Make some blue? Red? Yello?
etc.?
I saw another template AdminLTE, its 3.0 dev version updated so slow so i found stisla.
But I think stisla should learn from it about its colors.
White is too harsh. ( Or "dazzling"? I am so sorry for my poor English.)

@philiplambok

This comment has been minimized.

Copy link

philiplambok commented Mar 27, 2019

Yeah, I have the same concern about this, especially the green (success) color.

@nauvalazhar

This comment has been minimized.

Copy link
Member

nauvalazhar commented Mar 27, 2019

Hi, thank you for reporting the issue. Do you have good references for this? I will start working on this.

@jyxjjj

This comment has been minimized.

Copy link
Author

jyxjjj commented Mar 27, 2019

@nauvalazhar

I saw another template AdminLTE, its 3.0 dev version updated so slow so i found stisla.

But I think stisla should learn from it about its colors.

As i said, you may learn the color of AdminLTE 3.0.

If you want.

And I just think the sidebar and background were too bright, not others.

You used:
background-color: #000000;
or background-color: transparent;
or unset.

I think it is good to use:
#363F48 (My choice. I used it for my maintenance page.)
363F48
Or #ECF0F5 (From AdminLTE 2.4)
ECF0F5
Or #F4F6F9 (From AdminLTE 3)
F4F6F9
Or #343A40 (From AdminLTE 3).
343A40

Color picture may be small, may cause aberration, you should test in CSS.

@nauvalazhar

This comment has been minimized.

Copy link
Member

nauvalazhar commented Mar 27, 2019

A few weeks ago, someone made a pull request (#35) to change the contrast so it wasn't too bright.
Screenshot_121

And since version 2.1 I tried to swap the colors of the sidebar and navbar.
Screenshot_122

@jyxjjj

This comment has been minimized.

Copy link
Author

jyxjjj commented Mar 27, 2019

So, what's your plan now?
And I don't think one color can make everyone like it.
You can use cache like "localStorage" to save themes of different colors.
I think it's really worth learning AdminLTE, it provides many colors and css classes.
And save to localStorage can let users choose their favourite theme.
Eg., I don't like purple-blue, I like sky-blue.

@nauvalazhar

This comment has been minimized.

Copy link
Member

nauvalazhar commented Mar 28, 2019

I don't think about making other skin colors. It makes me slow to do something else. I will focus on something else, like documentation, and add other features.

@Agungkes

This comment has been minimized.

Copy link

Agungkes commented Apr 6, 2019

It's very great template so far. The color isn't not too brigth for me now.
And sure, more color is awesome.


Keren bro tema nya ^^ ditambahin aja saran bro kalau mau kontribusi di sini sama issues template biar gak berantakan nanti pas issue nya banyak :D Good job

@nauvalazhar

This comment has been minimized.

Copy link
Member

nauvalazhar commented Apr 7, 2019

Thank you for the advice, @Agungkes :)

@stefanturcanu

This comment has been minimized.

Copy link
Contributor

stefanturcanu commented Apr 9, 2019

@nauvalazhar now that it's open source ...maybe a new branch /dev with SCSS src files where we can make pull requests? 💡 🤔

or at least to have the option to download src files to change our own theme. find and replace can take you so far... 💪

@stefanturcanu

This comment has been minimized.

Copy link
Contributor

stefanturcanu commented Apr 9, 2019

@nauvalazhar now that it's open source ...maybe a new branch /dev with SCSS src files where we can make pull requests? 💡 🤔

or at least to have the option to download src files to change our own theme. find and replace can take you so far... 💪

my bad! just saw the releases 🙄 found the SCSS!

@cyberhck

This comment has been minimized.

Copy link

cyberhck commented Apr 10, 2019

actually I've an idea which you might like.

Instead of changing color schemes, simply split your scss into parts, say you have input.scss, split into input.scss and input.theme.scss and the theme file should do color, but the actual color should come from variable file,

When you build it, make 2 build files, one normal file which has everything not related to colors, and include one which only includes themes.

Once built, it should generate style.css and one style.theme.scss this way we can have multi theme application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.