Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for consolidation #626

Merged
merged 68 commits into from Apr 14, 2021
Merged

Prep for consolidation #626

merged 68 commits into from Apr 14, 2021

Conversation

erinkcochran87
Copy link
Contributor

@erinkcochran87 erinkcochran87 commented Apr 7, 2021

This PR cleans up a bunch of typos, links, unused files, and also cherry picks some commits from an older branch (add-page-keys). The purpose of doing that was to release a bunch of finished improvements that were blocked behind incomplete work on that branch.

The version menu wouldn't work on pages outside of the `destinations` collection, because this was only looking in that collection for matching page keys. This now uses `site.documents` instead of `site.destinations`, ensuring that pages outside the collection will use this menu correctly.
@erinkcochran87 erinkcochran87 merged commit 030c152 into master Apr 14, 2021
2 checks passed
@erinkcochran87 erinkcochran87 deleted the consolidation-cleanup branch April 14, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant