Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL/v2 #629

Merged
merged 11 commits into from Apr 19, 2021
Merged

MySQL/v2 #629

merged 11 commits into from Apr 19, 2021

Conversation

jazsmi
Copy link
Contributor

@jazsmi jazsmi commented Apr 13, 2021

High Performance version

@jazsmi
MySQL/v2
d1b8f70 
High Performance version
@jazsmi jazsmi self-assigned this Apr 13, 2021
erinkcochran87
erinkcochran87 suggested changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other things I noticed, but can't comment on since there aren't files to do so yet:

  • The version file needs to be updated to include v2
  • Changelog entry

_database-integrations/mysql/vanilla/mysql-v2.md Show resolved Hide resolved
_database-integrations/mysql/vanilla/mysql-v2.md Outdated Show resolved Hide resolved
_database-integrations/mysql/vanilla/mysql-v2.md Show resolved Hide resolved
_database-integrations/mysql/vanilla/mysql-v2.md Outdated Show resolved Hide resolved
_database-integrations/mysql/mysql-v2.md Outdated Show resolved Hide resolved
_database-integrations/mysql/vanilla/mysql-latest.md Outdated Show resolved Hide resolved
_developer-files/connect/api/objects/form-properties/sources/databases/hp-mysql-object.md Show resolved Hide resolved
@jazsmi jazsmi merged commit 08986c1 into master Apr 19, 2021
@jazsmi jazsmi deleted the mysql-v2 branch April 19, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erinkcochran87 erinkcochran87 erinkcochran87 approved these changes

Assignees

@jazsmi jazsmi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jazsmi @erinkcochran87